Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: third_party/WebKit/Source/core/animation/InterpolationType.h

Issue 2790083002: Add a virtual destructor for InterpolationType (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef InterpolationType_h 5 #ifndef InterpolationType_h
6 #define InterpolationType_h 6 #define InterpolationType_h
7 7
8 #include "core/animation/InterpolationValue.h" 8 #include "core/animation/InterpolationValue.h"
9 #include "core/animation/Keyframe.h" 9 #include "core/animation/Keyframe.h"
10 #include "core/animation/PairwiseInterpolationValue.h" 10 #include "core/animation/PairwiseInterpolationValue.h"
(...skipping 13 matching lines...) Expand all
24 // - Convert PropertySpecificKeyframe values to (Pairwise)?InterpolationValues: 24 // - Convert PropertySpecificKeyframe values to (Pairwise)?InterpolationValues:
25 // maybeConvertPairwise() and maybeConvertSingle() 25 // maybeConvertPairwise() and maybeConvertSingle()
26 // - Convert the target Element's property value to an InterpolationValue: 26 // - Convert the target Element's property value to an InterpolationValue:
27 // maybeConvertUnderlyingValue() 27 // maybeConvertUnderlyingValue()
28 // - Apply an InterpolationValue to a target Element's property: apply(). 28 // - Apply an InterpolationValue to a target Element's property: apply().
29 class InterpolationType { 29 class InterpolationType {
30 USING_FAST_MALLOC(InterpolationType); 30 USING_FAST_MALLOC(InterpolationType);
31 WTF_MAKE_NONCOPYABLE(InterpolationType); 31 WTF_MAKE_NONCOPYABLE(InterpolationType);
32 32
33 public: 33 public:
34 virtual ~InterpolationType() {}
35
34 PropertyHandle getProperty() const { return m_property; } 36 PropertyHandle getProperty() const { return m_property; }
35 37
36 // ConversionCheckers are returned from calls to maybeConvertPairwise() and 38 // ConversionCheckers are returned from calls to maybeConvertPairwise() and
37 // maybeConvertSingle() to enable the caller to check whether the result is 39 // maybeConvertSingle() to enable the caller to check whether the result is
38 // still valid given changes in the InterpolationEnvironment and underlying 40 // still valid given changes in the InterpolationEnvironment and underlying
39 // InterpolationValue. 41 // InterpolationValue.
40 class ConversionChecker { 42 class ConversionChecker {
41 USING_FAST_MALLOC(ConversionChecker); 43 USING_FAST_MALLOC(ConversionChecker);
42 WTF_MAKE_NONCOPYABLE(ConversionChecker); 44 WTF_MAKE_NONCOPYABLE(ConversionChecker);
43 45
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 117
116 protected: 118 protected:
117 InterpolationType(PropertyHandle property) : m_property(property) {} 119 InterpolationType(PropertyHandle property) : m_property(property) {}
118 120
119 const PropertyHandle m_property; 121 const PropertyHandle m_property;
120 }; 122 };
121 123
122 } // namespace blink 124 } // namespace blink
123 125
124 #endif // InterpolationType_h 126 #endif // InterpolationType_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698