DescriptionRevert of Avoid inline capacity of WordMeasurements (patchset #1 id:1 of https://codereview.chromium.org/2765353004/ )
Reason for revert:
Reverting due to 10.2%-11.9% regression in blink_perf.layout,
reported in issue 706907.
Original issue's description:
> Avoid inline capacity of WordMeasurements
>
> This patch disables the inline capacity of WordMeasurements but to
> reserve the heap once per line, in order to avoid stack overflow in
> LayoutBlockFlow::layoutRunsAndFloatsInRange() when stack is critical,
> such as when V8 initiates the layout.
>
> Currently, LayoutBlockFlow::layoutRunsAndFloatsInRange() is the only
> place we instantiate WordMeasurements.
>
> This change is expected to save stack space by ~2k.
>
> BUG=704536
>
> Review-Url: https://codereview.chromium.org/2765353004
> Cr-Commit-Position: refs/heads/master@{#459485}
> Committed: https://chromium.googlesource.com/chromium/src/+/704ca0cfcc046d199d31e6502639bc94b89fddb0
TBR=eae@chromium.org,dcheng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=704536, 706907
Review-Url: https://codereview.chromium.org/2789913002
Cr-Commit-Position: refs/heads/master@{#463172}
Committed: https://chromium.googlesource.com/chromium/src/+/165039831ad0a01bcc90b66d023c9d90dcc964d1
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase after the big rename #
Messages
Total messages: 23 (12 generated)
|