Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2789913002: Revert of Avoid inline capacity of WordMeasurements (Closed)

Created:
3 years, 8 months ago by kojii
Modified:
3 years, 8 months ago
Reviewers:
eae, dcheng
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Avoid inline capacity of WordMeasurements (patchset #1 id:1 of https://codereview.chromium.org/2765353004/ ) Reason for revert: Reverting due to 10.2%-11.9% regression in blink_perf.layout, reported in issue 706907. Original issue's description: > Avoid inline capacity of WordMeasurements > > This patch disables the inline capacity of WordMeasurements but to > reserve the heap once per line, in order to avoid stack overflow in > LayoutBlockFlow::layoutRunsAndFloatsInRange() when stack is critical, > such as when V8 initiates the layout. > > Currently, LayoutBlockFlow::layoutRunsAndFloatsInRange() is the only > place we instantiate WordMeasurements. > > This change is expected to save stack space by ~2k. > > BUG=704536 > > Review-Url: https://codereview.chromium.org/2765353004 > Cr-Commit-Position: refs/heads/master@{#459485} > Committed: https://chromium.googlesource.com/chromium/src/+/704ca0cfcc046d199d31e6502639bc94b89fddb0 TBR=eae@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=704536, 706907 Review-Url: https://codereview.chromium.org/2789913002 Cr-Commit-Position: refs/heads/master@{#463172} Committed: https://chromium.googlesource.com/chromium/src/+/165039831ad0a01bcc90b66d023c9d90dcc964d1

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase after the big rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 2 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
kojii
Created Revert of Avoid inline capacity of WordMeasurements
3 years, 8 months ago (2017-03-31 19:24:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789913002/1
3 years, 8 months ago (2017-03-31 19:25:41 UTC) #3
dcheng
lgtm
3 years, 8 months ago (2017-03-31 20:02:43 UTC) #4
eae
LGTM
3 years, 8 months ago (2017-04-03 22:39:18 UTC) #6
eae
(not sure we want to do this yet but if we do this is the ...
3 years, 8 months ago (2017-04-03 22:39:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789913002/1
3 years, 8 months ago (2017-04-10 03:05:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/187072) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 03:07:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789913002/60001
3 years, 8 months ago (2017-04-10 03:22:43 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/187075) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 03:24:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789913002/80001
3 years, 8 months ago (2017-04-10 04:10:57 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 05:30:47 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/165039831ad0a01bcc90b66d023c...

Powered by Google App Engine
This is Rietveld 408576698