Avoid inline capacity of WordMeasurements

Avoid inline capacity of WordMeasurements

This patch disables the inline capacity of WordMeasurements but to
reserve the heap once per line, in order to avoid stack overflow in
LayoutBlockFlow::layoutRunsAndFloatsInRange() when stack is critical,
such as when V8 initiates the layout.

Currently, LayoutBlockFlow::layoutRunsAndFloatsInRange() is the only
place we instantiate WordMeasurements.

This change is expected to save stack space by ~2k.

BUG=704536
Review-Url: https://codereview.chromium.org/2765353004
Cr-Commit-Position: refs/heads/master@{#459485}
Committed: https://chromium.googlesource.com/chromium/src/+/704ca0cfcc046d199d31e6502639bc94b89fddb0

[kojii, 2017-03-24 05:20:30]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 05:20:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-03-24 05:26:59]

Description was changed from

==========
wordmeasurements

BUG=
==========

to

==========
Avoid inline capacity of WordMeasurements

This patch disables the inline capacity of WordMeasurements but to
reserve the heap once per line, in order to avoid stack overflow in
LayoutBlockFlow::layoutRunsAndFloatsInRange() when stack is critical,
such as when V8 initiates the layout.

This change is expected to save stack space by ~2k.

BUG=704536
==========

[kojii, 2017-03-24 05:27:47]

Description was changed from

==========
Avoid inline capacity of WordMeasurements

This patch disables the inline capacity of WordMeasurements but to
reserve the heap once per line, in order to avoid stack overflow in
LayoutBlockFlow::layoutRunsAndFloatsInRange() when stack is critical,
such as when V8 initiates the layout.

This change is expected to save stack space by ~2k.

BUG=704536
==========

to

==========
Avoid inline capacity of WordMeasurements

This patch disables the inline capacity of WordMeasurements but to
reserve the heap once per line, in order to avoid stack overflow in
LayoutBlockFlow::layoutRunsAndFloatsInRange() when stack is critical,
such as when V8 initiates the layout.

Currently, LayoutBlockFlow::layoutRunsAndFloatsInRange() is the only
place we instantiate WordMeasurements.

This change is expected to save stack space by ~2k.

BUG=704536
==========

[kojii, 2017-03-24 05:28:28]

kojii@chromium.org changed reviewers:
+ dcheng@chromium.org, eae@chromium.org

[kojii, 2017-03-24 05:28:30]

eae@, do you think this is worth? govind@ said she wants to merge to stable if
possible.

[commit-bot: I haz the power, 2017-03-24 06:11:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 06:11:06]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eae, 2017-03-24 18:09:08]

Let's give it a try but I wouldn't merge it unless we have to

LGTM

[eae, 2017-03-24 18:09:23]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2017-03-24 18:10:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 18:35:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490378963762350, "parent_rev":
"62349ad779505d73be7c1dbd3db83dc9a38dc99f", "commit_rev":
"704ca0cfcc046d199d31e6502639bc94b89fddb0"}

[commit-bot: I haz the power, 2017-03-24 18:35:52]

Description was changed from

==========
Avoid inline capacity of WordMeasurements

This patch disables the inline capacity of WordMeasurements but to
reserve the heap once per line, in order to avoid stack overflow in
LayoutBlockFlow::layoutRunsAndFloatsInRange() when stack is critical,
such as when V8 initiates the layout.

Currently, LayoutBlockFlow::layoutRunsAndFloatsInRange() is the only
place we instantiate WordMeasurements.

This change is expected to save stack space by ~2k.

BUG=704536
==========

to

==========
Avoid inline capacity of WordMeasurements

This patch disables the inline capacity of WordMeasurements but to
reserve the heap once per line, in order to avoid stack overflow in
LayoutBlockFlow::layoutRunsAndFloatsInRange() when stack is critical,
such as when V8 initiates the layout.

Currently, LayoutBlockFlow::layoutRunsAndFloatsInRange() is the only
place we instantiate WordMeasurements.

This change is expected to save stack space by ~2k.

BUG=704536

Review-Url: https://codereview.chromium.org/2765353004
Cr-Commit-Position: refs/heads/master@{#459485}
Committed:
https://chromium.googlesource.com/chromium/src/+/704ca0cfcc046d199d31e6502639...
==========

[commit-bot: I haz the power, 2017-03-24 18:35:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/704ca0cfcc046d199d31e6502639...

[kojii, 2017-03-31 19:24:51]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2789913002/ by kojii@chromium.org.

The reason for reverting is: Reverting due to 10.2%-11.9% regression in
blink_perf.layout,
reported in issue 706907..