Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2789883004: Merge M58 [WebAPKs] Don't crash if WebAPK starts on page which displays interstitial (Closed)

Created:
3 years, 8 months ago by pkotwicz
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge M58 [WebAPKs] Don't crash if WebAPK starts on page which displays interstitial This CL: - Fixes "launch Chrome" intent to actually launch Chrome instead of Herb Chrome Custom Tab. - Finishes the WebAPK if there is no URL to navigate back to. BUG=658498 Review-Url: https://codereview.chromium.org/2752133002 Cr-Commit-Position: refs/heads/master@{#457682} (cherry picked from commit 33060182ee896b89c54ec758ac7fccc372e25c1a) Review-Url: https://codereview.chromium.org/2789883004 . Cr-Commit-Position: refs/branch-heads/3029@{#524} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/6db2798ee0ed98e89300a14e10a25cfe2659ff33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pkotwicz
3 years, 8 months ago (2017-04-01 01:29:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6db2798ee0ed98e89300a14e10a25cfe2659ff33.

Powered by Google App Engine
This is Rietveld 408576698