Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2752133002: [WebAPKs] Don't crash if WebAPK starts on page which displays interstitial (Closed)

Created:
3 years, 9 months ago by pkotwicz
Modified:
3 years, 9 months ago
Reviewers:
Xi Han, gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebAPKs] Don't crash if WebAPK starts on page which displays interstitial This CL: - Fixes "launch Chrome" intent to actually launch Chrome instead of Herb Chrome Custom Tab. - Finishes the WebAPK if there is no URL to navigate back to. BUG=658498 Review-Url: https://codereview.chromium.org/2752133002 Cr-Commit-Position: refs/heads/master@{#457682} Committed: https://chromium.googlesource.com/chromium/src/+/33060182ee896b89c54ec758ac7fccc372e25c1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pkotwicz
Xi, can you please take a look?
3 years, 9 months ago (2017-03-15 21:09:24 UTC) #2
Xi Han
LGTM!
3 years, 9 months ago (2017-03-16 19:43:17 UTC) #4
pkotwicz
Dan for OWNERS
3 years, 9 months ago (2017-03-16 19:59:52 UTC) #6
gone
lgtm
3 years, 9 months ago (2017-03-16 20:06:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752133002/1
3 years, 9 months ago (2017-03-17 03:36:48 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 04:19:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/33060182ee896b89c54ec758ac7f...

Powered by Google App Engine
This is Rietveld 408576698