Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2789863002: Sort procedures by source positions. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -20 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_class_builder.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/accessors.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/accessors.dart.outline.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000025.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/rasta/issue_000025.dart.outline.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/rasta/super.dart.outline.expect View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/test/fasta/super_rasta_copy.dart.direct.expect View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/test/fasta/super_rasta_copy.dart.outline.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/top_level_accessors.dart.direct.expect View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/top_level_accessors.dart.outline.expect View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
As I'm preparing to have separate scopes for setters, I've noticed that we emitted getters ...
3 years, 8 months ago (2017-03-31 14:36:47 UTC) #2
karlklose
LGTM
3 years, 8 months ago (2017-04-03 06:19:38 UTC) #3
ahe
3 years, 8 months ago (2017-04-04 09:25:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc1d179cae1ba63bc48213148815ab5b01d9fa15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698