Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2785883005: Make top-level scope implicit. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 2 chunks +1 line, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/scope_listener.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 2 chunks +1 line, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
3 years, 8 months ago (2017-03-31 14:38:33 UTC) #2
karlklose
LGTM
3 years, 8 months ago (2017-04-03 06:20:22 UTC) #3
ahe
3 years, 8 months ago (2017-04-04 09:35:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68ae0771615febfd67b94437904092af9c29156e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698