Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2794533002: Move scope.dart. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -236 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/fasta/analyzer.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/analyzer_diet_listener.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/class_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/function_type_builder.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/mixin_application_builder.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/named_type_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/prefix_builder.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/procedure_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
D pkg/front_end/lib/src/fasta/builder/scope.dart View 1 chunk +0 lines, -190 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/type_builder.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/front_end/lib/src/fasta/scope.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/scope_listener.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2790893002 Patch 1

Dependent Patchsets:

Issue 2789863002 Patch 1

Messages

Total messages: 5 (2 generated)
ahe
3 years, 8 months ago (2017-03-31 14:34:12 UTC) #2
karlklose
LGTM
3 years, 8 months ago (2017-04-03 06:18:53 UTC) #3
ahe
3 years, 8 months ago (2017-04-04 09:00:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
babf66241f9556aa10d40c4d777e94ac9f4a2d28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698