Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2789653002: cleanup: Remove the system tray bubble crash investigation CHECK (Closed)

Created:
3 years, 8 months ago by Qiang(Joe) Xu
Modified:
3 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cleanup: Remove the system tray bubble crash investigation CHECK Changes: Now that Clusterfuzz reports crash fixed in crbug.com/702267, it is time to remove the check induced in crrev.com/2392183002. BUG=702267 BUG=651242 TEST=none Review-Url: https://codereview.chromium.org/2789653002 Cr-Commit-Position: refs/heads/master@{#461523} Committed: https://chromium.googlesource.com/chromium/src/+/78581ae9b930e09bb0640986eb693d703dde905c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M ash/common/system/tray/system_tray.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/tray/system_tray.cc View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Qiang(Joe) Xu
3 years, 8 months ago (2017-03-30 17:13:29 UTC) #3
oshima
lgtm
3 years, 8 months ago (2017-04-03 19:57:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2789653002/1
3 years, 8 months ago (2017-04-03 20:08:03 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 20:40:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78581ae9b930e09bb0640986eb69...

Powered by Google App Engine
This is Rietveld 408576698