cleanup: Remove the system tray bubble crash investigation CHECK

ash/common/system/tray/system_tray.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/system_tray.h"
 
 #include <algorithm>
 #include <map>
 #include <vector>
 
@@ skipping 403 matching lines @@
   return system_bubble_->bubble();
 }
 
 bool SystemTray::IsSystemBubbleVisible() const {
   return HasSystemBubble() && system_bubble_->bubble()->IsVisible();
 }
 
 bool SystemTray::CloseSystemBubble() const {
   if (!system_bubble_)
     return false;
-  CHECK(!activating_);
   system_bubble_->bubble()->Close();
   return true;
 }
 
 views::View* SystemTray::GetHelpButtonView() const {
   return tray_tiles_->GetHelpButtonView();
 }
 
 TrayAudio* SystemTray::GetTrayAudio() const {
   return tray_audio_;
@@ skipping 225 matching lines @@
   return tray_tiles_;
 }
 
 void SystemTray::CloseBubble(const ui::KeyEvent& key_event) {
   CloseSystemBubble();
 }
 
 void SystemTray::ActivateAndStartNavigation(const ui::KeyEvent& key_event) {
   if (!system_bubble_)
     return;
-  activating_ = true;
   ActivateBubble();
-  activating_ = false;
-  // TODO(oshima): This is to troubleshoot the issue crbug.com/651242. Remove
-  // once the root cause is fixed.
-  CHECK(system_bubble_) << " the bubble was deleted while activaing it";
 
   views::Widget* widget = GetSystemBubble()->bubble_view()->GetWidget();
   widget->GetFocusManager()->OnKeyEvent(key_event);
 }
 
 void SystemTray::CreateKeyEventWatcher() {
   key_event_watcher_ = WmShell::Get()->CreateKeyEventWatcher();
   // mustash does not yet support KeyEventWatcher. http://crbug.com/649600.
   if (!key_event_watcher_)
     return;
@@ skipping 27 matching lines @@
     system_bubble_->bubble()->Close();
   } else {
     ShowDefaultView(BUBBLE_CREATE_NEW);
     if (event.IsKeyEvent() || (event.flags() & ui::EF_TOUCH_ACCESSIBILITY))
       ActivateBubble();
   }
   return true;
 }
 
 void SystemTray::CloseSystemBubbleAndDeactivateSystemTray() {
-  CHECK(!activating_);
   activation_observer_.reset();
   key_event_watcher_.reset();
   system_bubble_.reset();
   // When closing a system bubble with the alternate shelf layout, we need to
   // turn off the active tinting of the shelf.
   if (full_system_tray_menu_) {
     SetIsActive(false);
     full_system_tray_menu_ = false;
   }
 }
@@ skipping 19 matching lines @@
           .work_area()
           .height();
   if (work_area_height > 0) {
     UMA_HISTOGRAM_CUSTOM_COUNTS(
         "Ash.SystemMenu.PercentageOfWorkAreaHeightCoveredByMenu",
         100 * bubble_view->height() / work_area_height, 1, 300, 100);
   }
 }
 
 }  // namespace ash