Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2789643002: [Merge to M58]Chrome OS: revert the device wallpaper change within a user session. (Closed)

Created:
3 years, 8 months ago by xdai1
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Merge to M58]Chrome OS: revert the device wallpaper change within a user session. The device policy should never leak to a user's session. In the old CL https://codereview.chromium.org/2572793003 we use the device policy controlled wallpaper as the user wallpaper within a user's session if there is no user wallpaper policy controlled wallpaper and no user- defined wallpaper. This CL reverted this logic. Note this CL is not a clean fix since I want to keep it simple to merge back to M58. I'll do a cleaner fix after it's been merged. BUG=705028 TBR=alemate@chromium.org Review-Url: https://codereview.chromium.org/2772973003 Cr-Commit-Position: refs/heads/master@{#460281} (cherry picked from commit 8c8e69e14bebb66cba7f31887865d76b24817080) Review-Url: https://codereview.chromium.org/2789643002 . Cr-Commit-Position: refs/branch-heads/3029@{#492} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/11a148da1e362e8ac74aebe84a1e5495208bc2b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -40 lines) Patch
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 2 chunks +7 lines, -27 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.h View 1 chunk +2 lines, -6 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
xdai1
3 years, 8 months ago (2017-03-30 17:10:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
11a148da1e362e8ac74aebe84a1e5495208bc2b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698