Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2772973003: Chrome OS: revert the device wallpaper change within a user session. (Closed)

Created:
3 years, 9 months ago by xdai1
Modified:
3 years, 8 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Chrome OS: revert the device wallpaper change within a user session. The device policy should never leak to a user's session. In the old CL https://codereview.chromium.org/2572793003 we use the device policy controlled wallpaper as the user wallpaper within a user's session if there is no user wallpaper policy controlled wallpaper and no user- defined wallpaper. This CL reverted this logic. Note this CL is not a clean fix since I want to keep it simple to merge back to M58. I'll do a cleaner fix after it's been merged. BUG=705028 Review-Url: https://codereview.chromium.org/2772973003 Cr-Commit-Position: refs/heads/master@{#460281} Committed: https://chromium.googlesource.com/chromium/src/+/8c8e69e14bebb66cba7f31887865d76b24817080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -40 lines) Patch
M chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc View 2 chunks +7 lines, -27 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.h View 1 chunk +2 lines, -6 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
xdai1
alemate@, could you help review this CL please? I need revert some changes that was ...
3 years, 9 months ago (2017-03-24 19:13:28 UTC) #4
xdai1
On 2017/03/24 19:13:28, xdai1 wrote: > alemate@, could you help review this CL please? I ...
3 years, 9 months ago (2017-03-27 17:19:21 UTC) #9
Alexander Alekseev
lgtm
3 years, 8 months ago (2017-03-29 01:40:09 UTC) #10
Alexander Alekseev
lgtm
3 years, 8 months ago (2017-03-29 01:40:37 UTC) #11
Alexander Alekseev
lgtm lgtm
3 years, 8 months ago (2017-03-29 01:40:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772973003/1
3 years, 8 months ago (2017-03-29 01:41:13 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 8 months ago (2017-03-29 03:42:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2772973003/1
3 years, 8 months ago (2017-03-29 04:05:01 UTC) #18
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 04:57:22 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c8e69e14bebb66cba7f31887865...

Powered by Google App Engine
This is Rietveld 408576698