Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 278923003: Revert of Android-side of insertion/selection handles visibility. (Closed)

Created:
6 years, 7 months ago by jdduke (slow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, aelias_OOO_until_Jul13
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Android-side of insertion/selection handles visibility. (https://codereview.chromium.org/188023002/) Reason for revert: There are a number of cases where this incorrectly hides the selection/insertion handles in an editable node. Original issue's description: > Android-side of insertion/selection handles visibility. > > This patch relies on other two patches: > https://codereview.chromium.org/177903010/ > https://codereview.chromium.org/186753002/ > to correctly compute the visibility of selection and > insertion handles when editing text input, text area > and contenteditable elements. > > BUG=236033 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258839 BUG=372056 TBR=tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269667

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -209 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 5 chunks +0 lines, -35 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/CursorController.java View 1 chunk +6 lines, -25 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/HandleView.java View 3 chunks +2 lines, -14 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/InsertionHandleController.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/SelectionHandleController.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/InsertionHandleTest.java View 1 chunk +0 lines, -29 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/SelectionHandleTest.java View 5 chunks +7 lines, -86 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jdduke (slow)
Created Revert of Android-side of insertion/selection handles visibility.
6 years, 7 months ago (2014-05-09 23:26:28 UTC) #1
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 7 months ago (2014-05-09 23:26:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/278923003/1
6 years, 7 months ago (2014-05-09 23:27:12 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-09 23:27:13 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-09 23:27:14 UTC) #5
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-05-09 23:27:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/278923003/1
6 years, 7 months ago (2014-05-09 23:31:31 UTC) #7
mlamouri (slow - plz ping)
The CQ bit was unchecked by mlamouri@chromium.org
6 years, 7 months ago (2014-05-10 13:07:11 UTC) #8
mlamouri (slow - plz ping)
I do not think we should do this revert. There is a very simple fix ...
6 years, 7 months ago (2014-05-10 13:16:33 UTC) #9
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-05-10 13:48:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/278923003/1
6 years, 7 months ago (2014-05-10 13:50:00 UTC) #11
jdduke (slow)
On 2014/05/10 13:07:11, Mounir Lamouri wrote: > The CQ bit was unchecked by mailto:mlamouri@chromium.org In ...
6 years, 7 months ago (2014-05-10 14:16:38 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 01:08:17 UTC) #13
Message was sent while issue was closed.
Change committed as 269667

Powered by Google App Engine
This is Rietveld 408576698