Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/CursorController.java

Issue 278923003: Revert of Android-side of insertion/selection handles visibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/CursorController.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/CursorController.java b/content/public/android/java/src/org/chromium/content/browser/input/CursorController.java
index 5bf4bada8af023347ff231547ad4ce5ce526df80..68f88bc950386cbd86cc722649930ef4e7127ea8 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/CursorController.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/CursorController.java
@@ -4,57 +4,38 @@
package org.chromium.content.browser.input;
-import android.graphics.Rect;
import android.view.ViewTreeObserver;
/**
* A CursorController instance can be used to control a cursor in the text.
*/
-abstract class CursorController implements ViewTreeObserver.OnTouchModeChangeListener {
-
- private Rect mVisibleClippingRectangle;
+interface CursorController extends ViewTreeObserver.OnTouchModeChangeListener {
/**
* Hide the cursor controller from screen.
*/
- abstract void hide();
+ void hide();
/**
* @return true if the CursorController is currently visible
*/
- abstract boolean isShowing();
+ boolean isShowing();
/**
* Called when the handle is about to start updating its position.
* @param handle
*/
- abstract void beforeStartUpdatingPosition(HandleView handle);
+ void beforeStartUpdatingPosition(HandleView handle);
/**
* Update the controller's position.
*/
- abstract void updatePosition(HandleView handle, int x, int y);
+ void updatePosition(HandleView handle, int x, int y);
/**
* Called when the view is detached from window. Perform house keeping task, such as
* stopping Runnable thread that would otherwise keep a reference on the context, thus
* preventing the activity to be recycled.
*/
- abstract void onDetached();
-
- /**
- * Sets the visible rectangle for text input elements as supplied by Blink.
- */
- public void setVisibleClippingRectangle(int left, int top, int right, int bottom) {
- if (mVisibleClippingRectangle == null) {
- mVisibleClippingRectangle = new Rect(left, top, right, bottom);
- } else {
- mVisibleClippingRectangle.set(left,top,right,bottom);
- }
- }
-
- Rect getVisibleClippingRectangle() {
- return mVisibleClippingRectangle;
- }
-
+ void onDetached();
}

Powered by Google App Engine
This is Rietveld 408576698