Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/HandleView.java

Issue 278923003: Revert of Android-side of insertion/selection handles visibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/HandleView.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/HandleView.java b/content/public/android/java/src/org/chromium/content/browser/input/HandleView.java
index b8bac44a4cad98f35f370f71bcbee6c61e357fa3..e41efcfdfd053684238c41ed651870883aadae57 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/HandleView.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/HandleView.java
@@ -18,8 +18,6 @@
import android.view.animation.AnimationUtils;
import android.widget.PopupWindow;
-import com.google.common.annotations.VisibleForTesting;
-
import org.chromium.content.browser.PositionObserver;
/**
@@ -232,8 +230,7 @@
return mContainer.isShowing();
}
- @VisibleForTesting
- boolean isPositionVisible() {
+ private boolean isPositionVisible() {
// Always show a dragging handle.
if (mIsDragging) {
return true;
@@ -253,17 +250,8 @@
final int posX = getContainerPositionX() + (int) mHotspotX;
final int posY = getContainerPositionY() + (int) mHotspotY;
- boolean result = posX >= clip.left && posX <= clip.right &&
+ return posX >= clip.left && posX <= clip.right &&
posY >= clip.top && posY <= clip.bottom;
-
- final Rect clippingRect = mController.getVisibleClippingRectangle();
- if (result && clippingRect != null) {
- // We need to clip against the visible areas as supplied by Blink,
- // e.g. textaread and text input elements.
- return clippingRect.contains(getAdjustedPositionX(), getAdjustedPositionY());
- }
-
- return result;
}
// x and y are in physical pixels.

Powered by Google App Engine
This is Rietveld 408576698