Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 2788683005: Migrate WTF::RefVector::append() to ::push_back() (Closed)

Created:
3 years, 8 months ago by pilgrim_google
Modified:
3 years, 8 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, rwlbuis, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::RefVector::append() to ::push_back() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2788683005 Cr-Commit-Position: refs/heads/master@{#461366} Committed: https://chromium.googlesource.com/chromium/src/+/b06db87db43c1d78a7e23b87383fd61e011bb8b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/RefVector.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
pilgrim_google
3 years, 8 months ago (2017-03-31 18:25:52 UTC) #3
haraken
LGTM
3 years, 8 months ago (2017-03-31 23:02:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788683005/1
3 years, 8 months ago (2017-04-03 02:35:49 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 03:55:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b06db87db43c1d78a7e23b87383f...

Powered by Google App Engine
This is Rietveld 408576698