Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2788683005: Migrate WTF::RefVector::append() to ::push_back() (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * * Redistributions of source code must retain the above copyright 4 * * Redistributions of source code must retain the above copyright
5 * notice, this list of conditions and the following disclaimer. 5 * notice, this list of conditions and the following disclaimer.
6 * * Redistributions in binary form must reproduce the above 6 * * Redistributions in binary form must reproduce the above
7 * copyright notice, this list of conditions and the following disclaimer 7 * copyright notice, this list of conditions and the following disclaimer
8 * in the documentation and/or other materials provided with the 8 * in the documentation and/or other materials provided with the
9 * distribution. 9 * distribution.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
(...skipping 1138 matching lines...) Expand 10 before | Expand all | Expand 10 after
1149 StyleResolverState& state, 1149 StyleResolverState& state,
1150 const CSSValue& value) { 1150 const CSSValue& value) {
1151 if (!value.isValueList()) 1151 if (!value.isValueList())
1152 return SVGComputedStyle::initialStrokeDashArray(); 1152 return SVGComputedStyle::initialStrokeDashArray();
1153 1153
1154 const CSSValueList& dashes = toCSSValueList(value); 1154 const CSSValueList& dashes = toCSSValueList(value);
1155 1155
1156 RefPtr<SVGDashArray> array = SVGDashArray::create(); 1156 RefPtr<SVGDashArray> array = SVGDashArray::create();
1157 size_t length = dashes.length(); 1157 size_t length = dashes.length();
1158 for (size_t i = 0; i < length; ++i) { 1158 for (size_t i = 0; i < length; ++i) {
1159 array->append(convertLength(state, toCSSPrimitiveValue(dashes.item(i)))); 1159 array->push_back(convertLength(state, toCSSPrimitiveValue(dashes.item(i))));
1160 } 1160 }
1161 1161
1162 return array.release(); 1162 return array.release();
1163 } 1163 }
1164 1164
1165 StyleColor StyleBuilderConverter::convertStyleColor(StyleResolverState& state, 1165 StyleColor StyleBuilderConverter::convertStyleColor(StyleResolverState& state,
1166 const CSSValue& value, 1166 const CSSValue& value,
1167 bool forVisitedLink) { 1167 bool forVisitedLink) {
1168 if (value.isIdentifierValue() && 1168 if (value.isIdentifierValue() &&
1169 toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor) 1169 toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor)
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
1402 } 1402 }
1403 1403
1404 const CSSValue& StyleBuilderConverter::convertRegisteredPropertyValue( 1404 const CSSValue& StyleBuilderConverter::convertRegisteredPropertyValue(
1405 const StyleResolverState& state, 1405 const StyleResolverState& state,
1406 const CSSValue& value) { 1406 const CSSValue& value) {
1407 return computeRegisteredPropertyValue(state.cssToLengthConversionData(), 1407 return computeRegisteredPropertyValue(state.cssToLengthConversionData(),
1408 value); 1408 value);
1409 } 1409 }
1410 1410
1411 } // namespace blink 1411 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698