Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2788663002: Bugfix - a DCHECK could allocate, invalidating a raw pointer. (Closed)

Created:
3 years, 8 months ago by mvstanton
Modified:
3 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Bugfix - a DCHECK could allocate, invalidating a raw pointer. HasOrigin() can allocate. Make sure to wrap vulnerable raw pointers in handles. BUG= Review-Url: https://codereview.chromium.org/2788663002 Cr-Commit-Position: refs/heads/master@{#44271} Committed: https://chromium.googlesource.com/v8/v8/+/5bc286e54e88fdcdacb02c82b895345a410ebe8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/compilation-cache.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
mvstanton
Hi Toon, Thanks for noticing this bug! --Michael
3 years, 8 months ago (2017-03-30 14:28:51 UTC) #4
Toon Verwaest
lgtm
3 years, 8 months ago (2017-03-30 14:30:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788663002/1
3 years, 8 months ago (2017-03-30 14:32:49 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 14:50:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5bc286e54e88fdcdacb02c82b895345a410...

Powered by Google App Engine
This is Rietveld 408576698