Bugfix - a DCHECK could allocate, invalidating a raw pointer.

src/compilation-cache.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compilation-cache.h"
 
 #include "src/counters.h"
 #include "src/factory.h"
 #include "src/globals.h"
 #include "src/objects-inl.h"
@@ skipping 152 matching lines @@
         result = InfoVectorPair(*function_info,
                                 probe.has_vector() ? *vector_handle : nullptr);
       }
     }
   }
 
   // Once outside the manacles of the handle scope, we need to recheck
   // to see if we actually found a cached script. If so, we return a
   // handle created in the caller's handle scope.
   if (result.has_shared()) {
+#ifdef DEBUG
+    // Since HasOrigin can allocate, we need to protect the SharedFunctionInfo
+    // and the FeedbackVector with handles during the call.
     Handle<SharedFunctionInfo> shared(result.shared(), isolate());
-    // TODO(mvstanton): Make sure HasOrigin can't allocate, or it will
-    // mess up our InfoVectorPair.
+    Handle<Cell> vector_handle;
+    if (result.has_vector()) {
+      vector_handle = Handle<Cell>(result.vector(), isolate());
+    }
     DCHECK(
         HasOrigin(shared, name, line_offset, column_offset, resource_options));
+    result =
+        InfoVectorPair(*shared, result.has_vector() ? *vector_handle : nullptr);
+#endif
     isolate()->counters()->compilation_cache_hits()->Increment();
   } else {
     isolate()->counters()->compilation_cache_misses()->Increment();
   }
   return result;
 }
 
 void CompilationCacheScript::Put(Handle<String> source, Handle<Context> context,
                                  LanguageMode language_mode,
                                  Handle<SharedFunctionInfo> function_info,
@@ skipping 197 matching lines @@
 
 
 void CompilationCache::Disable() {
   enabled_ = false;
   Clear();
 }
 
 
 }  // namespace internal
 }  // namespace v8