chrome/browser/extensions/crx_installer.h - Issue 2788563002: Transfer DictionaryValue ownership in SandboxedUnpacker::OnUnpackSuccess()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.h

Issue 2788563002: Transfer DictionaryValue ownership in SandboxedUnpacker::OnUnpackSuccess() (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/crx_installer.h

diff --git a/chrome/browser/extensions/crx_installer.h b/chrome/browser/extensions/crx_installer.h

index 9f73dd36b434622c3620dcd8116354154c67b15d..9c38aeb9f55e923972eff1a76f11c6c89852a238 100644

--- a/chrome/browser/extensions/crx_installer.h

+++ b/chrome/browser/extensions/crx_installer.h

@@ -232,7 +232,7 @@ class CrxInstaller : public SandboxedUnpackerClient {

void OnUnpackFailure(const CrxInstallError& error) override;

void OnUnpackSuccess(const base::FilePath& temp_dir,

const base::FilePath& extension_dir,

- const base::DictionaryValue* original_manifest,

+ std::unique_ptr<base::DictionaryValue> original_manifest,

const Extension* extension,

const SkBitmap& install_icon) override;