chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc - Issue 2788563002: Transfer DictionaryValue ownership in SandboxedUnpacker::OnUnpackSuccess()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

Issue 2788563002: Transfer DictionaryValue ownership in SandboxedUnpacker::OnUnpackSuccess() (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_external_update_validator.h ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

diff --git a/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc b/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

index d4409a9d3e4255624ebb2978ac81ad0857f9424f..0622c012d8e656a54901b8cda4ba26236ae0e555 100644

--- a/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

+++ b/chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc

@@ -52,7 +52,7 @@ void KioskExternalUpdateValidator::OnUnpackFailure(

void KioskExternalUpdateValidator::OnUnpackSuccess(

const base::FilePath& temp_dir,

const base::FilePath& extension_dir,

- const base::DictionaryValue* original_manifest,

+ std::unique_ptr<base::DictionaryValue> original_manifest,

const extensions::Extension* extension,

const SkBitmap& install_icon) {

DCHECK(crx_file_.extension_id == extension->id());

« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_external_update_validator.h ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »