Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: chrome/browser/extensions/crx_installer.h

Issue 2788563002: Transfer DictionaryValue ownership in SandboxedUnpacker::OnUnpackSuccess() (Closed)
Patch Set: address comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 void ConvertWebAppOnFileThread(const WebApplicationInfo& web_app); 225 void ConvertWebAppOnFileThread(const WebApplicationInfo& web_app);
226 226
227 // Called after OnUnpackSuccess as a last check to see whether the install 227 // Called after OnUnpackSuccess as a last check to see whether the install
228 // should complete. 228 // should complete.
229 CrxInstallError AllowInstall(const Extension* extension); 229 CrxInstallError AllowInstall(const Extension* extension);
230 230
231 // SandboxedUnpackerClient 231 // SandboxedUnpackerClient
232 void OnUnpackFailure(const CrxInstallError& error) override; 232 void OnUnpackFailure(const CrxInstallError& error) override;
233 void OnUnpackSuccess(const base::FilePath& temp_dir, 233 void OnUnpackSuccess(const base::FilePath& temp_dir,
234 const base::FilePath& extension_dir, 234 const base::FilePath& extension_dir,
235 const base::DictionaryValue* original_manifest, 235 std::unique_ptr<base::DictionaryValue> original_manifest,
236 const Extension* extension, 236 const Extension* extension,
237 const SkBitmap& install_icon) override; 237 const SkBitmap& install_icon) override;
238 238
239 // Called on the UI thread to start the requirements, policy and blacklist 239 // Called on the UI thread to start the requirements, policy and blacklist
240 // checks on the extension. 240 // checks on the extension.
241 void CheckInstall(); 241 void CheckInstall();
242 242
243 // Runs on the UI thread. Callback from ExtensionInstallChecker. 243 // Runs on the UI thread. Callback from ExtensionInstallChecker.
244 void OnInstallChecksComplete(int failed_checks); 244 void OnInstallChecksComplete(int failed_checks);
245 245
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
441 441
442 // Performs requirements, policy and blacklist checks on the extension. 442 // Performs requirements, policy and blacklist checks on the extension.
443 std::unique_ptr<ExtensionInstallChecker> install_checker_; 443 std::unique_ptr<ExtensionInstallChecker> install_checker_;
444 444
445 DISALLOW_COPY_AND_ASSIGN(CrxInstaller); 445 DISALLOW_COPY_AND_ASSIGN(CrxInstaller);
446 }; 446 };
447 447
448 } // namespace extensions 448 } // namespace extensions
449 449
450 #endif // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_ 450 #endif // CHROME_BROWSER_EXTENSIONS_CRX_INSTALLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/app_mode/kiosk_external_update_validator.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698