Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2788513004: [disasm] Print all pc offsets as hex (Closed)

Created:
3 years, 8 months ago by Clemens Hammacher
Modified:
3 years, 8 months ago
Reviewers:
Yang, Leszek Swirski
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[disasm] Print all pc offsets as hex The disassembly output recently changed to output pc offsets in hex (see https://codereview.chromium.org/2757263002). This CL also changes source positions, safepoints and back edges to use the same format. This allows easier matching. R=leszeks@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/2788513004 Cr-Commit-Position: refs/heads/master@{#44294} Committed: https://chromium.googlesource.com/v8/v8/+/85ff725cf4d48361f8c12495f23f68dd48dd2e29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/objects.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Clemens Hammacher
3 years, 8 months ago (2017-03-30 15:58:24 UTC) #5
Leszek Swirski
lgtm
3 years, 8 months ago (2017-03-30 16:02:01 UTC) #6
Yang
On 2017/03/30 16:02:01, Leszek Swirski wrote: > lgtm lgtm.
3 years, 8 months ago (2017-03-31 05:47:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788513004/1
3 years, 8 months ago (2017-03-31 08:58:48 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 09:00:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/85ff725cf4d48361f8c12495f23f68dd48d...

Powered by Google App Engine
This is Rietveld 408576698