Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2757263002: [disasm] Make jump target printing perf friendly (Closed)

Created:
3 years, 9 months ago by Leszek Swirski
Modified:
3 years, 9 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[disasm] Make jump target printing perf friendly Makes disassembly jump target printing look more like the output of objdump, for compatibility with perf's jump arrows. This includes swapping the order of address and offset, and making the offset and line numbers hex. As a drive-by, print comment lines in objdump-v8 so that they can be shown/hidden as "source" lines by perf. Review-Url: https://codereview.chromium.org/2757263002 Cr-Commit-Position: refs/heads/master@{#43940} Committed: https://chromium.googlesource.com/v8/v8/+/dc789377a1a6ef4a50e100830ff83cbc3b98dba4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M src/disassembler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/objdump-v8 View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Leszek Swirski
Hi Yang, Continuing my previous CL trying to make things more perf friendly, here's one ...
3 years, 9 months ago (2017-03-20 14:41:36 UTC) #6
Yang
On 2017/03/20 14:41:36, Leszek Swirski wrote: > Hi Yang, > Continuing my previous CL trying ...
3 years, 9 months ago (2017-03-20 14:44:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2757263002/1
3 years, 9 months ago (2017-03-20 14:45:30 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 14:47:11 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dc789377a1a6ef4a50e100830ff83cbc3b9...

Powered by Google App Engine
This is Rietveld 408576698