third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2788473003: Use EphmeralRange insteadof Range in CompositeEditCommands::isNodeVisiblyContainedWithin()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2788473003: Use EphmeralRange insteadof Range in CompositeEditCommands::isNodeVisiblyContainedWithin()

Patch Set: update Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('K') | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index e8cc4e3e39f63adcbc3f843aeea08fd0efd06f88..e252dec496f99936a90b3b652372e41c3d04998d 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -1970,12 +1970,12 @@ void CompositeEditCommand::setParent(CompositeEditCommand* parent) {

// visibly fit inside selectedRange

bool CompositeEditCommand::isNodeVisiblyContainedWithin(

Node& node,

- const Range& selectedRange) {

+ const EphemeralRange& selectedRange) {

DCHECK(!needsLayoutTreeUpdate(node));

DocumentLifecycle::DisallowTransitionScope disallowTransition(

node.document().lifecycle());

- if (isNodeFullyContained(EphemeralRange(&selectedRange), node))

+ if (isNodeFullyContained(selectedRange, node))

return true;

bool startIsVisuallySame =