Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2788453002: Revert of macOS: Fix a bug in logic to get all memory regions. (Closed)

Created:
3 years, 8 months ago by stgao
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of macOS: Fix a bug in logic to get all memory regions. (patchset #1 id:1 of https://codereview.chromium.org/2786733004/ ) Reason for revert: This failed ProcessMetricsMemoryDumpProviderTest.NoDuplicateRegions on "Mac ASan 64 Tests (1)". https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/28499 Original issue's description: > macOS: Fix a bug in logic to get all memory regions. > > The logic was accidentally double-counting the size of a memory region, causing > some memory regions to get skipped. > > BUG=706547 > > Review-Url: https://codereview.chromium.org/2786733004 > Cr-Commit-Position: refs/heads/master@{#460585} > Committed: https://chromium.googlesource.com/chromium/src/+/f955ebf64b34ec9cbdcb137c00bc9bba1867d071 TBR=primiano@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=706547 Review-Url: https://codereview.chromium.org/2788453002 Cr-Commit-Position: refs/heads/master@{#460619} Committed: https://chromium.googlesource.com/chromium/src/+/6387395d1a02579a33652086a64384311d576ba0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/tracing/common/process_metrics_memory_dump_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
stgao
Created Revert of macOS: Fix a bug in logic to get all memory regions.
3 years, 8 months ago (2017-03-30 01:42:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788453002/1
3 years, 8 months ago (2017-03-30 01:43:21 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 01:51:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6387395d1a02579a33652086a643...

Powered by Google App Engine
This is Rietveld 408576698