macOS: Fix a bug in logic to get all memory regions.

macOS: Fix a bug in logic to get all memory regions.

The logic was accidentally double-counting the size of a memory region, causing
some memory regions to get skipped.

BUG=706547
Review-Url: https://codereview.chromium.org/2786733004
Cr-Commit-Position: refs/heads/master@{#460585}
Committed: https://chromium.googlesource.com/chromium/src/+/f955ebf64b34ec9cbdcb137c00bc9bba1867d071

[erikchen, 2017-03-29 21:30:39]

erikchen@chromium.org changed reviewers:
+ primiano@chromium.org

[erikchen, 2017-03-29 21:30:39]

primiano: Please review.

[erikchen, 2017-03-29 22:03:25]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 22:05:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2017-03-29 23:36:48]

lgtm

[Primiano Tucci (use gerrit), 2017-03-29 23:36:48]

lgtm

lgtm

[Primiano Tucci (use gerrit), 2017-03-29 23:37:26]

(I swear I clicked once but, hey, http)

[erikchen, 2017-03-29 23:37:27]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2017-03-29 23:37:27]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-03-29 23:38:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2017-03-29 23:38:54]

On 2017/03/29 23:37:26, Primiano Tucci wrote:
> (I swear I clicked once but, hey, http)

That would explain a second post, but a post with 2 instances of lgtm?
*suspicious*

[Primiano Tucci (use gerrit), 2017-03-29 23:41:18]

On 2017/03/29 23:38:54, erikchen wrote:
> On 2017/03/29 23:37:26, Primiano Tucci wrote:
> > (I swear I clicked once but, hey, http)
> 
> That would explain a second post, but a post with 2 instances of lgtm?
> *suspicious*

I used the quick lgtm button. I guess something went wrong in the sequence
textarea.append(),form.submit(). Who knows. This isn't the most mobile friendly
codereview system :/

[erikchen, 2017-03-29 23:42:27]

reviews on mobile? *impressed at tenacity and daring*

On Wed, Mar 29, 2017 at 4:41 PM, <primiano@chromium.org> wrote:

> On 2017/03/29 23:38:54, erikchen wrote:
> > On 2017/03/29 23:37:26, Primiano Tucci wrote:
> > > (I swear I clicked once but, hey, http)
> >
> > That would explain a second post, but a post with 2 instances of lgtm?
> > *suspicious*
>
> I used the quick lgtm button. I guess something went wrong in the sequence
> textarea.append(),form.submit(). Who knows. This isn't the most mobile
> friendly
> codereview system :/
>
> https://codereview.chromium.org/2786733004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-03-29 23:59:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490830647580910, "parent_rev":
"6ff2dbc1c7424cd12b6ac35ec438eb3057dc65d8", "commit_rev":
"f955ebf64b34ec9cbdcb137c00bc9bba1867d071"}

[commit-bot: I haz the power, 2017-03-29 23:59:55]

Description was changed from

==========
macOS: Fix a bug in logic to get all memory regions.

The logic was accidentally double-counting the size of a memory region, causing
some memory regions to get skipped.

BUG=706547
==========

to

==========
macOS: Fix a bug in logic to get all memory regions.

The logic was accidentally double-counting the size of a memory region, causing
some memory regions to get skipped.

BUG=706547

Review-Url: https://codereview.chromium.org/2786733004
Cr-Commit-Position: refs/heads/master@{#460585}
Committed:
https://chromium.googlesource.com/chromium/src/+/f955ebf64b34ec9cbdcb137c00bc...
==========

[commit-bot: I haz the power, 2017-03-29 23:59:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f955ebf64b34ec9cbdcb137c00bc...

[stgao, 2017-03-30 01:42:10]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2788453002/ by stgao@chromium.org.

The reason for reverting is: This failed
ProcessMetricsMemoryDumpProviderTest.NoDuplicateRegions on "Mac ASan 64 Tests
(1)".

https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromiu....