Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2788423003: [regexp] Updates for unicode escapes in capture names (Closed)

Created:
3 years, 8 months ago by jgruber
Modified:
3 years, 8 months ago
Reviewers:
Dan Ehrenberg, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Updates for unicode escapes in capture names Update docs and tests for recent changes in the spec for unicode escapes in capture group names. https://github.com/tc39/proposal-regexp-named-groups/issues/23 BUG=v8:5437 Review-Url: https://codereview.chromium.org/2788423003 Cr-Commit-Position: refs/heads/master@{#44474} Committed: https://chromium.googlesource.com/v8/v8/+/f3b848fe5d1dcca6a2e490e5b5674d551f7d27db

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address comments and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M src/regexp/regexp-parser.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M test/mjsunit/harmony/regexp-named-captures.js View 1 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
jgruber
3 years, 8 months ago (2017-04-04 07:43:30 UTC) #4
Yang
lgtm https://codereview.chromium.org/2788423003/diff/1/test/mjsunit/harmony/regexp-named-captures.js File test/mjsunit/harmony/regexp-named-captures.js (right): https://codereview.chromium.org/2788423003/diff/1/test/mjsunit/harmony/regexp-named-captures.js#newcode188 test/mjsunit/harmony/regexp-named-captures.js:188: assertThrows("/(?<a\\uD801>.)/u", SyntaxError); // \u Lead Also test the ...
3 years, 8 months ago (2017-04-05 08:03:36 UTC) #7
jgruber
https://codereview.chromium.org/2788423003/diff/1/test/mjsunit/harmony/regexp-named-captures.js File test/mjsunit/harmony/regexp-named-captures.js (right): https://codereview.chromium.org/2788423003/diff/1/test/mjsunit/harmony/regexp-named-captures.js#newcode188 test/mjsunit/harmony/regexp-named-captures.js:188: assertThrows("/(?<a\\uD801>.)/u", SyntaxError); // \u Lead On 2017/04/05 08:03:35, Yang ...
3 years, 8 months ago (2017-04-07 08:01:23 UTC) #8
jgruber
https://codereview.chromium.org/2788423003/diff/1/test/mjsunit/harmony/regexp-named-captures.js File test/mjsunit/harmony/regexp-named-captures.js (right): https://codereview.chromium.org/2788423003/diff/1/test/mjsunit/harmony/regexp-named-captures.js#newcode188 test/mjsunit/harmony/regexp-named-captures.js:188: assertThrows("/(?<a\\uD801>.)/u", SyntaxError); // \u Lead On 2017/04/07 08:01:23, jgruber ...
3 years, 8 months ago (2017-04-07 08:02:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788423003/20001
3 years, 8 months ago (2017-04-07 08:28:16 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 08:57:49 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f3b848fe5d1dcca6a2e490e5b5674d551f7...

Powered by Google App Engine
This is Rietveld 408576698