Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Unified Diff: src/regexp/regexp-parser.cc

Issue 2788423003: [regexp] Updates for unicode escapes in capture names (Closed)
Patch Set: Address comments and rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/harmony/regexp-named-captures.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/regexp/regexp-parser.cc
diff --git a/src/regexp/regexp-parser.cc b/src/regexp/regexp-parser.cc
index 656e88cff89578f0ab488b0392956b681ace48a8..3f9c505c499d58020317486c97a5f1f5fd868933 100644
--- a/src/regexp/regexp-parser.cc
+++ b/src/regexp/regexp-parser.cc
@@ -700,10 +700,6 @@ void RegExpParser::ScanForCaptures() {
if (current() != '<') break;
if (FLAG_harmony_regexp_lookbehind) {
- // TODO(jgruber): To be more future-proof we could test for
- // IdentifierStart here once it becomes clear whether group names
- // allow unicode escapes.
- // https://github.com/tc39/proposal-regexp-named-groups/issues/23
Advance();
if (current() == '=' || current() == '!') break;
}
@@ -783,8 +779,6 @@ const ZoneVector<uc16>* RegExpParser::ParseCaptureGroupName() {
// Convert unicode escapes.
if (c == '\\' && current() == 'u') {
- // TODO(jgruber): Reconsider this once the spec has settled.
- // https://github.com/tc39/proposal-regexp-named-groups/issues/23
Advance(scan_mode);
if (!ParseUnicodeEscape(&c)) {
ReportError(CStrVector("Invalid Unicode escape sequence"));
« no previous file with comments | « no previous file | test/mjsunit/harmony/regexp-named-captures.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698