third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html - Issue 2788373003: Convert colorSettings attribute in ImageData.idl to a getter method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html

Issue 2788373003: Convert colorSettings attribute in ImageData.idl to a getter method (Closed)

Patch Set: Addressing comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html

diff --git a/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html b/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html

index 9ff17a809b0e3cabbca2d432332d8d85b334831d..2d5d56d99a86e39403271cc3decb7822edbba957 100644

--- a/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html

+++ b/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html

@@ -28,22 +28,22 @@ function runTest(colorSettings, expectedColorSettings) {

imageData = experimental.createImageData(1, 1, colorSettings);

checkDataTypeAgainstStorageFormat(imageData.dataUnion, colorSettings.storageFormat);

assert_array_equals(imageData.dataUnion, [0, 0, 0, 0]);

- checkColorSettings(imageData.colorSettings, expectedColorSettings.colorSpace, expectedColorSettings.storageFormat);

+ checkColorSettings(imageData.getColorSettings(), expectedColorSettings.colorSpace, expectedColorSettings.storageFormat);

imageData = experimental.createImageData(dataU8, 1, 1, colorSettings);

assert_equals(Object.prototype.toString.call(imageData.dataUnion), "[object Uint8ClampedArray]");

assert_array_equals(imageData.dataUnion, dataU8);

- checkColorSettings(imageData.colorSettings, expectedColorSettings.colorSpace, "uint8");

+ checkColorSettings(imageData.getColorSettings(), expectedColorSettings.colorSpace, "uint8");

imageData = experimental.createImageData(dataU16, 1, 1, colorSettings);

assert_equals(Object.prototype.toString.call(imageData.dataUnion), "[object Uint16Array]");

assert_array_equals(imageData.dataUnion, dataU16);

- checkColorSettings(imageData.colorSettings, expectedColorSettings.colorSpace, "uint16");

+ checkColorSettings(imageData.getColorSettings(), expectedColorSettings.colorSpace, "uint16");

imageData = experimental.createImageData(dataF32, 1, 1, colorSettings);

assert_equals(Object.prototype.toString.call(imageData.dataUnion), "[object Float32Array]");

assert_array_equals(imageData.dataUnion, dataF32);

- checkColorSettings(imageData.colorSettings, expectedColorSettings.colorSpace, "float32");

+ checkColorSettings(imageData.getColorSettings(), expectedColorSettings.colorSpace, "float32");

}

var testScenarios = [