Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2788363002: Use enum hack to define kInvalidCdmId. (Closed)

Created:
3 years, 8 months ago by Max Morin
Modified:
3 years, 8 months ago
Reviewers:
DaleCurtis
CC:
audio-mojo-cl_google.com, chromium-reviews, feature-media-reviews_chromium.org, o1ka
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use enum hack to define kInvalidCdmId. When adding media/mojo/services as a dependency of content/browser, the initialization in https://cs.chromium.org/chromium/src/media/mojo/services/mojo_cdm_service.cc?l=74 causes offence to the Linux builder, since it is dynamically initialized. This is fixed by defining kInvalidCdmId in the header file. I verified I could reproduce the issue reported in https://codereview.chromium.org/2788173002/ before this CL, but not after. BUG=None Review-Url: https://codereview.chromium.org/2788363002 Cr-Commit-Position: refs/heads/master@{#461652} Committed: https://chromium.googlesource.com/chromium/src/+/565e54c04c1b33ae517caa33a0ba64448fd5c56a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M media/base/cdm_context.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/cdm_context.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Max Morin
Dale: PTAL.
3 years, 8 months ago (2017-04-03 08:19:53 UTC) #4
DaleCurtis
lgtm
3 years, 8 months ago (2017-04-03 18:43:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788363002/1
3 years, 8 months ago (2017-04-04 07:09:03 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 07:15:18 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/565e54c04c1b33ae517caa33a0ba...

Powered by Google App Engine
This is Rietveld 408576698