Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2788173002: Revert of Add mojo interface+impl creation of audio streams. (Closed)

Created:
3 years, 8 months ago by caseq
Modified:
3 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, asvitkine+watch_chromium.org, audio-mojo-cl_google.com, chromium-reviews, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, Guido Urdaneta, jam, miu+watch_chromium.org, ossu-chromium, posciak+watch_chromium.org, qsr+mojo_chromium.org, Solis, viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add mojo interface+impl creation of audio streams. (patchset #9 id:360001 of https://codereview.chromium.org/2697663003/ ) Reason for revert: Broke sizes test on linux x64: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/36560 Original issue's description: > Add mojo interface+impl creation of audio streams. > > Summary: > * RendererAudioOutputStreamFactory is an interface for creating > AudioOutputProviders. > * Since a lot of data is common for all factories of a single renderer > process, it is held in a context object. > (AudioOutputStreamFactoryContext is per-process and > RendererAudioOutputStreamFactory is per-frame). > * Replaces AudioRendererHost (eventually, after field trials). > * Follow-up on https://codereview.chromium.org/2697793002/. > * Design doc at https://docs.google.com/document/d/1awQoajq_DLmz2AIU9iweC0zEYlVuHCvEIRQepeYyxh8/edit > * audio_output_stream_factory_context_impl_unittest.cc is actually an > integration test, but it seems common to suffix test files with > "_unittest" anyways, so I did that. > > > BUG=425368 > > Review-Url: https://codereview.chromium.org/2697663003 > Cr-Commit-Position: refs/heads/master@{#461103} > Committed: https://chromium.googlesource.com/chromium/src/+/8757b429c30f14d20697f7c6fe4dfdd510cf0b7f TBR=dalecurtis@chromium.org,asvitkine@chromium.org,avi@chromium.org,mkwst@chromium.org,olka@chromium.org,rockot@chromium.org,maxmorin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=425368 Review-Url: https://codereview.chromium.org/2788173002 Cr-Commit-Position: refs/heads/master@{#461157} Committed: https://chromium.googlesource.com/chromium/src/+/925d324b60de6538885b1f74b214b7ca76caca1a

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
caseq
Created Revert of Add mojo interface+impl creation of audio streams.
3 years, 8 months ago (2017-03-31 17:15:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788173002/1
3 years, 8 months ago (2017-03-31 17:16:00 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/925d324b60de6538885b1f74b214b7ca76caca1a
3 years, 8 months ago (2017-03-31 17:21:22 UTC) #6
Max Morin
3 years, 8 months ago (2017-04-04 07:22:56 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2792293002/ by maxmorin@chromium.org.

The reason for reverting is: Fixed issue:
https://codereview.chromium.org/2788363002/. Reusing LGTMs since the CL is
unchanged..

Powered by Google App Engine
This is Rietveld 408576698