Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Issue 2788123002: MIPS[64]: Fix `[es2015] Simplify contract between parser and stub for derived constructors.` (Closed)

Created:
3 years, 8 months ago by ivica.bogosavljevic
Modified:
3 years, 8 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS[64]: Fix `[es2015] Simplify contract between parser and stub for derived constructors.` Fix 776d89f9ce6e043972c1e611aa8cfaf2feb1fb78 Fix typo in MIPS implementation BUG= Review-Url: https://codereview.chromium.org/2788123002 Cr-Commit-Position: refs/heads/master@{#44337} Committed: https://chromium.googlesource.com/v8/v8/+/928a9462c9407d889255d61bc112c86874dd317b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/builtins/mips/builtins-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
ivica.bogosavljevic
PTAL
3 years, 8 months ago (2017-03-31 12:00:22 UTC) #3
ivica.bogosavljevic
On 2017/03/31 12:00:22, ivica.bogosavljevic wrote: > PTAL Since this is a one-line fix related to ...
3 years, 8 months ago (2017-04-03 12:08:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788123002/1
3 years, 8 months ago (2017-04-03 12:21:23 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-03 12:21:25 UTC) #12
ivica.bogosavljevic
lgtm
3 years, 8 months ago (2017-04-03 12:22:00 UTC) #13
Benedikt Meurer
lgtm
3 years, 8 months ago (2017-04-03 13:10:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788123002/1
3 years, 8 months ago (2017-04-03 13:11:06 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-03 13:12:28 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/928a9462c9407d889255d61bc112c86874d...

Powered by Google App Engine
This is Rietveld 408576698