Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: src/builtins/mips/builtins-mips.cc

Issue 2788123002: MIPS[64]: Fix `[es2015] Simplify contract between parser and stub for derived constructors.` (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/mips64/builtins-mips64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/mips/builtins-mips.cc
diff --git a/src/builtins/mips/builtins-mips.cc b/src/builtins/mips/builtins-mips.cc
index 6a895566d33147e78772520ee4b6213648e236d5..a3c27b1ce5880e4d6a0bd1ab8861bab5658eed83 100644
--- a/src/builtins/mips/builtins-mips.cc
+++ b/src/builtins/mips/builtins-mips.cc
@@ -580,7 +580,7 @@ void Generate_JSConstructStubHelper(MacroAssembler* masm, bool is_api_function,
// from a derived class is neither undefined nor an Object.
if (check_derived_construct) {
Label do_throw, dont_throw;
- __ JumpIfNotSmi(v0, &do_throw);
+ __ JumpIfSmi(v0, &do_throw);
__ GetObjectType(v0, a1, a3);
STATIC_ASSERT(LAST_JS_RECEIVER_TYPE == LAST_TYPE);
__ Branch(&dont_throw, greater_equal, a3, Operand(FIRST_JS_RECEIVER_TYPE));
« no previous file with comments | « no previous file | src/builtins/mips64/builtins-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698