Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2788093002: Add missing header files to GN files (3 of N) (Closed)

Created:
3 years, 8 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, binji+watch_chromium.org, yzshen+watch_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, net-reviews_chromium.org, Sam Clegg, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ios-reviews_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, darin-cc_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, fuzzing_chromium.org, sdefresne+watch_chromium.org, pkl (ping after 24h if needed), Aaron Boodman, darin (slow to review), tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing header files to GN files (3 of N) I ran check_gn_headers.py on Mac and iOS full builds, merged the missing header file list, fed to fix_gn_headers.py (without AddHeadersToSources), and manually fixed the results. Read more about the manual fixes in the Review-Url. The number of missing header files on Mac and iOS decreased by 54, from 814 to 760. None of the fixed files are included in the following spreadsheet: https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0 fix_gn_headers.py is from https://codereview.chromium.org/2790563003 BUG=661774 Review-Url: https://codereview.chromium.org/2788093002 Cr-Commit-Position: refs/heads/master@{#461999} Committed: https://chromium.googlesource.com/chromium/src/+/ebb66ffb22611d7cc1a50711b0c3eb5a609a5a79

Patch Set 1 : run script #

Patch Set 2 : apply manual fixes from https://crrev.com/2784393003 #

Patch Set 3 : manual fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M components/os_crypt/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/fuzzer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/tabs/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/BUILD.gn View 2 chunks +48 lines, -0 lines 0 comments Download
M net/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/boringssl/BUILD.generated_tests.gni View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/flatbuffers/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
wychen
PTAL. This is for Mac and iOS.
3 years, 8 months ago (2017-03-31 16:44:08 UTC) #8
Nico
lgtm
3 years, 8 months ago (2017-03-31 16:53:52 UTC) #9
wychen
Brett, could you take a look? Thanks!
3 years, 8 months ago (2017-03-31 16:59:34 UTC) #11
brettw
lgtm
3 years, 8 months ago (2017-03-31 17:13:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2788093002/40001
3 years, 8 months ago (2017-04-05 06:23:48 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 07:20:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ebb66ffb22611d7cc1a50711b0c3...

Powered by Google App Engine
This is Rietveld 408576698