Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2784393003: Add missing header files to GN files (2 of N) (Closed)

Created:
3 years, 8 months ago by wychen
Modified:
3 years, 8 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, darin (slow to review), cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, imcheng+watch_chromium.org, Aaron Boodman, qsr+mojo_chromium.org, avayvod+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, blink-reviews-frames_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, blink-reviews, xjz+watch_chromium.org, net-reviews_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing header files to GN files (2 of N) I ran check_gn_headers.py on linux and android full builds, merged the missing header file lists, fed to fix_gn_headers.py (without AddHeadersToSources), chose which matches to apply interactively, and manually fixed the results. Read more about the manual fixes in the Review-Url. The number of missing header files on linux and android decreased by 7, from 836 to 829. None of the fixed files are included in the following spreadsheet: https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs/edit#gid=0 fix_gn_headers.py is from https://codereview.chromium.org/2790563003 BUG=661774 Review-Url: https://codereview.chromium.org/2784393003 Cr-Commit-Position: refs/heads/master@{#461318} Committed: https://chromium.googlesource.com/chromium/src/+/36575ffb10df9cdee4a9d0fe7d0e34c44323ea8f

Patch Set 1 : run script interactively #

Patch Set 2 : apply manual fixes from https://crrev.com/2778153002 #

Patch Set 3 : manual fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/nacl/renderer/plugin/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M media/cast/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/win/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/leveldatabase/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/openh264/openh264_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/wds/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 37 (30 generated)
wychen
PTAL. This is based on new version of the script, and interactively picking which match ...
3 years, 8 months ago (2017-03-31 16:43:34 UTC) #23
Nico
lgtm
3 years, 8 months ago (2017-03-31 16:52:47 UTC) #24
wychen
Brett, could you take a look? Thanks.
3 years, 8 months ago (2017-03-31 16:58:50 UTC) #26
brettw
lgtm
3 years, 8 months ago (2017-03-31 17:14:36 UTC) #28
commit-bot: I haz the power
This CL has an open dependency (Issue 2790563003 Patch 20001). Please resolve the dependency and ...
3 years, 8 months ago (2017-04-01 05:41:55 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2784393003/60001
3 years, 8 months ago (2017-04-01 05:45:55 UTC) #34
commit-bot: I haz the power
3 years, 8 months ago (2017-04-01 05:52:17 UTC) #37
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/36575ffb10df9cdee4a9d0fe7d0e...

Powered by Google App Engine
This is Rietveld 408576698