Fixing select all for contenteditable

third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index d5881a9b3d9ff2c8768ed4514f7e2bc38a4e262d..df8847e0b6e510ececf727b6eebf5dc3d1037f3c 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -11567,7 +11567,7 @@ bool testSelectAll(const std::string& html) {
                            WebInputEvent::TimeStampForTesting);
 
   mouseEvent.button = WebMouseEvent::Button::Right;
-  mouseEvent.setPositionInWidget(10, 10);
+  mouseEvent.setPositionInWidget(8, 8);
   mouseEvent.clickCount = 1;
   webView->handleInputEvent(WebCoalescedInputEvent(mouseEvent));
   runPendingTasks();
@@ -11580,8 +11580,7 @@ TEST_F(WebFrameTest, ContextMenuData) {
   EXPECT_TRUE(testSelectAll("<textarea>nonempty</textarea>"));
   EXPECT_FALSE(testSelectAll("<input>"));
   EXPECT_TRUE(testSelectAll("<input value='nonempty'>"));
-  // TODO(amaralp): Empty contenteditable should not have select all enabled.
-  EXPECT_TRUE(testSelectAll("<div contenteditable></div>"));
+  EXPECT_FALSE(testSelectAll("<div contenteditable></div>"));
   EXPECT_TRUE(testSelectAll("<div contenteditable>nonempty</div>"));

[yosin_UTC9, 2017/04/06 08:27:27]

Could you add |EXPECT_TRUE(testSelectAll("<div contenteditable>\n</div>"));|?

[amaralp, 2017/04/06 21:51:21]

Done.

 }