Add GetPreferredFormats method to media::VideoCapturerSource.

Add GetPreferredFormats method to media::VideoCapturerSource.

GetCurrentSupportedFormats is deprecated and reimplemented on
top of GetPreferredFormats by default.

This is in anticipation to spec-compliant video constraints processing,
where device capabilities are queried before the device is selected.

BUG=657733
Review-Url: https://codereview.chromium.org/2787773002
Cr-Commit-Position: refs/heads/master@{#462223}
Committed: https://chromium.googlesource.com/chromium/src/+/9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6

[Guido Urdaneta, 2017-03-30 09:47:47]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 09:48:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 09:58:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 09:58:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Guido Urdaneta, 2017-03-30 11:32:55]

Patchset #1 (id:1) has been deleted

[Guido Urdaneta, 2017-03-30 11:44:00]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 11:44:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-03-30 12:09:50]

guidou@chromium.org changed reviewers:
+ mcasas@chromium.org, mkwst@chromium.org, tommi@chromium.org

[Guido Urdaneta, 2017-03-30 12:09:50]

mkwst@chromium.org: Please review changes in content/shell

tommi@chromium.org: Please review changes in chrome/renderer/media and
content/renderer/media

mcasas@chromium.org: Please review changes in media/capture and
content/renderer/media_capture_from_element

[commit-bot: I haz the power, 2017-03-30 13:09:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 13:09:33]

Dry run: This issue passed the CQ dry run.

[Mike West, 2017-03-30 14:41:44]

//content/shell LGTM.

[Guido Urdaneta, 2017-04-03 09:33:40]

Description was changed from

==========
Add GetPreferredFormats method to media::VideoCapturerSource.

GetCurrentSupportedFormats is deprecated and reimplemented on
top of GetPreferredFormats by default.

This is in anticipation to spec-compliant video constraints processing,
where device capabilities are queried before the device is selected.

BUG=657733
==========

to

==========
Add GetPreferredFormats method to media::VideoCapturerSource.

GetCurrentSupportedFormats is deprecated and reimplemented on
top of GetPreferredFormats by default.

This is in anticipation to spec-compliant video constraints processing,
where device capabilities are queried before the device is selected.

BUG=657733
==========

[Guido Urdaneta, 2017-04-04 11:34:37]

guidou@chromium.org changed reviewers:
- tommi@chromium.org

[Guido Urdaneta, 2017-04-04 11:51:05]

guidou@chromium.org changed reviewers:
+ miu@chromium.org

[Guido Urdaneta, 2017-04-04 11:51:05]

miu@chromium.org: Can you take a look at chrome/renderer/media and
content/renderer/media?

[mcasas, 2017-04-04 18:40:28]

On 2017/04/04 11:51:05, Guido Urdaneta wrote:
> mailto:miu@chromium.org: Can you take a look at chrome/renderer/media and
> content/renderer/media?

media_capture_from_element/* lgtm

[Guido Urdaneta, 2017-04-05 16:55:06]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 16:55:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Guido Urdaneta, 2017-04-05 17:14:29]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 17:14:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 19:06:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 19:06:38]

Dry run: This issue passed the CQ dry run.

[miu, 2017-04-05 20:58:36]

lgtm % nit:

https://codereview.chromium.org/2787773002/diff/40001/media/capture/video_cap...
File media/capture/video_capturer_source.h (right):

https://codereview.chromium.org/2787773002/diff/40001/media/capture/video_cap...
media/capture/video_capturer_source.h:59: virtual void
GetCurrentSupportedFormats(
Does this still need to be a virtual method (are there overrides in subclasses)?

[Guido Urdaneta, 2017-04-05 21:14:59]

thanks everyone for the review.

https://codereview.chromium.org/2787773002/diff/40001/media/capture/video_cap...
File media/capture/video_capturer_source.h (right):

https://codereview.chromium.org/2787773002/diff/40001/media/capture/video_cap...
media/capture/video_capturer_source.h:59: virtual void
GetCurrentSupportedFormats(
On 2017/04/05 20:58:36, miu wrote:
> Does this still need to be a virtual method (are there overrides in
subclasses)?

Yes, LocalVideoCapturerSource (defined in user_media_client_impl.cc) still has
an implementation of it, but we will remove the method in a future iteration
when we retire the old constraints algorithm.

[Guido Urdaneta, 2017-04-05 21:15:06]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2017-04-05 21:15:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2787773002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-04-05 21:16:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 21:29:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491426906453700,
"parent_rev": "ed002f4219ce4cdced3d29e5a018a2fcdad09b72", "commit_rev":
"9f7541c77a83aa2a946d3227dbbbcc5eb1983ca6"}

[commit-bot: I haz the power, 2017-04-05 21:30:57]

Description was changed from

==========
Add GetPreferredFormats method to media::VideoCapturerSource.

GetCurrentSupportedFormats is deprecated and reimplemented on
top of GetPreferredFormats by default.

This is in anticipation to spec-compliant video constraints processing,
where device capabilities are queried before the device is selected.

BUG=657733
==========

to

==========
Add GetPreferredFormats method to media::VideoCapturerSource.

GetCurrentSupportedFormats is deprecated and reimplemented on
top of GetPreferredFormats by default.

This is in anticipation to spec-compliant video constraints processing,
where device capabilities are queried before the device is selected.

BUG=657733

Review-Url: https://codereview.chromium.org/2787773002
Cr-Commit-Position: refs/heads/master@{#462223}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f7541c77a83aa2a946d3227dbbb...
==========

[commit-bot: I haz the power, 2017-04-05 21:30:59]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f7541c77a83aa2a946d3227dbbb...