Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: content/renderer/media_capture_from_element/canvas_capture_handler.cc

Issue 2787773002: Add GetPreferredFormats method to media::VideoCapturerSource. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media_capture_from_element/canvas_capture_handler.cc
diff --git a/content/renderer/media_capture_from_element/canvas_capture_handler.cc b/content/renderer/media_capture_from_element/canvas_capture_handler.cc
index 9273798043a40059379e659cd82d09107596643b..a7e852038fbf76945d36ddd182727f5784558331 100644
--- a/content/renderer/media_capture_from_element/canvas_capture_handler.cc
+++ b/content/renderer/media_capture_from_element/canvas_capture_handler.cc
@@ -49,11 +49,7 @@ class VideoCapturerSource : public media::VideoCapturerSource {
}
protected:
- void GetCurrentSupportedFormats(
- int max_requested_width,
- int max_requested_height,
- double max_requested_frame_rate,
- const VideoCaptureDeviceFormatsCB& callback) override {
+ media::VideoCaptureFormats GetPreferredFormats() override {
DCHECK(main_render_thread_checker_.CalledOnValidThread());
const blink::WebSize& size = canvas_handler_->GetSourceSize();
media::VideoCaptureFormats formats;
@@ -63,7 +59,7 @@ class VideoCapturerSource : public media::VideoCapturerSource {
formats.push_back(
media::VideoCaptureFormat(gfx::Size(size.width, size.height),
frame_rate_, media::PIXEL_FORMAT_YV12A));
- callback.Run(formats);
+ return formats;
}
void StartCapture(const media::VideoCaptureParams& params,
const VideoCaptureDeliverFrameCB& frame_callback,

Powered by Google App Engine
This is Rietveld 408576698