Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2787463003: Step #2 in streaming the kernel flowgraph (Closed)

Created:
3 years, 8 months ago by jensj
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Step #2 in streaming the kernel flowgraph * Stream InvalidExpression * Stream NullLiteral * Stream BoolLiteral * Stream IntLiteral * Stream ThisExpression * Stream StringLitereal R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/42c80b590646739e8753a41d4eef03f037c7ff6b

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -34 lines) Patch
M runtime/vm/kernel_binary.cc View 7 chunks +17 lines, -4 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.h View 1 chunk +28 lines, -2 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 7 chunks +113 lines, -19 lines 1 comment Download
M runtime/vm/kernel_to_il.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 4 chunks +11 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
jensj
3 years, 8 months ago (2017-03-29 13:48:58 UTC) #2
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/2787463003/diff/1/runtime/vm/kernel_binary_flowgraph.cc File runtime/vm/kernel_binary_flowgraph.cc (right): https://codereview.chromium.org/2787463003/diff/1/runtime/vm/kernel_binary_flowgraph.cc#newcode216 runtime/vm/kernel_binary_flowgraph.cc:216: intptr_t savedOffset = reader_->offset(); Maybe it would be ...
3 years, 8 months ago (2017-03-31 12:05:41 UTC) #3
jensj
3 years, 8 months ago (2017-04-03 10:04:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
42c80b590646739e8753a41d4eef03f037c7ff6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698