Step #2 in streaming the kernel flowgraph

runtime/vm/kernel_to_il.cc

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <map>
 #include <set>
 #include <string>
 
 #include "vm/kernel_to_il.h"
 
@@ skipping 1023 matching lines @@
 const dart::String& TranslationHelper::DartSymbol(const char* content) const {
   return dart::String::ZoneHandle(Z, Symbols::New(thread_, content));
 }
 
 
 dart::String& TranslationHelper::DartSymbol(String* content) const {
   return dart::String::ZoneHandle(
       Z, dart::Symbols::FromUTF8(thread_, content->buffer(), content->size()));
 }
 
+dart::String& TranslationHelper::DartSymbol(const uint8_t* utf8_array,
+                                            intptr_t len) const {
+  return dart::String::ZoneHandle(
+      Z, dart::Symbols::FromUTF8(thread_, utf8_array, len));
+}
 
 const dart::String& TranslationHelper::DartClassName(
     CanonicalName* kernel_klass) {
   dart::String& name = DartString(kernel_klass->name());
   return ManglePrivateName(kernel_klass->parent(), &name);
 }
 
 
 const dart::String& TranslationHelper::DartConstructorName(Constructor* node) {
   Class* klass = Class::Cast(node->parent());
@@ skipping 3178 matching lines @@
     arguments->data()[i] = stack_->definition()->AsPushArgument();
     Drop();
   }
   pending_argument_count_ -= count;
   ASSERT(pending_argument_count_ >= 0);
   return arguments;
 }
 
 
 void FlowGraphBuilder::VisitInvalidExpression(InvalidExpression* node) {
-  // The frontend will take care of emitting normal errors (like
-  // [NoSuchMethodError]s) and only emit [InvalidExpression]s in very special
-  // situations (e.g. an invalid annotation).
-  fragment_ = ThrowNoSuchMethodError();
+  fragment_ = streaming_flow_graph_builder_->BuildAt(node->kernel_offset());
 }
 
 
 void FlowGraphBuilder::VisitNullLiteral(NullLiteral* node) {
-  fragment_ = Constant(Instance::ZoneHandle(Z, Instance::null()));
+  fragment_ = streaming_flow_graph_builder_->BuildAt(node->kernel_offset());
 }
 
 
 void FlowGraphBuilder::VisitBoolLiteral(BoolLiteral* node) {
-  fragment_ = Constant(Bool::Get(node->value()));
+  fragment_ = streaming_flow_graph_builder_->BuildAt(node->kernel_offset());
 }
 
 
 void FlowGraphBuilder::VisitIntLiteral(IntLiteral* node) {
-  fragment_ = IntConstant(node->value());
+  fragment_ = streaming_flow_graph_builder_->BuildAt(node->kernel_offset());
 }
 
 
 void FlowGraphBuilder::VisitBigintLiteral(BigintLiteral* node) {
   const dart::String& value = H.DartString(node->value());
   fragment_ = Constant(Integer::ZoneHandle(Z, Integer::New(value, Heap::kOld)));
 }
 
 
 void FlowGraphBuilder::VisitDoubleLiteral(DoubleLiteral* node) {
   fragment_ = Constant(constant_evaluator_.EvaluateExpression(node));
 }
 
 
 void FlowGraphBuilder::VisitStringLiteral(StringLiteral* node) {
-  fragment_ = Constant(H.DartSymbol(node->value()));
+  fragment_ = streaming_flow_graph_builder_->BuildAt(node->kernel_offset());
 }
 
 
 void FlowGraphBuilder::VisitSymbolLiteral(SymbolLiteral* node) {
   fragment_ = Constant(constant_evaluator_.EvaluateExpression(node));
 }
 
 
 AbstractType& DartTypeTranslator::TranslateType(DartType* node) {
   node->AcceptDartTypeVisitor(this);
@@ skipping 886 matching lines @@
 
 void FlowGraphBuilder::VisitNot(Not* node) {
   Fragment instructions = TranslateExpression(node->expression());
   instructions += CheckBooleanInCheckedMode();
   instructions += BooleanNegate();
   fragment_ = instructions;
 }
 
 
 void FlowGraphBuilder::VisitThisExpression(ThisExpression* node) {
-  fragment_ = LoadLocal(scopes_->this_variable);
+  fragment_ = streaming_flow_graph_builder_->BuildAt(node->kernel_offset());
 }
 
 
 void FlowGraphBuilder::VisitStringConcatenation(StringConcatenation* node) {
   List<Expression>& expressions = node->expressions();
 
   Fragment instructions;
 
   if (node->expressions().length() == 1) {
     instructions += TranslateExpression(node->expressions()[0]);
@@ skipping 1264 matching lines @@
     thread->clear_sticky_error();
     return error.raw();
   }
 }
 
 
 }  // namespace kernel
 }  // namespace dart
 
 #endif  // !defined(DART_PRECOMPILED_RUNTIME)