Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2781313003: Add kernel_offset to all expressions; Make KernelConstMapKeyEqualsTraits use kernel_offset (Closed)

Created:
3 years, 8 months ago by jensj
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add kernel_offset to all expressions; Make KernelConstMapKeyEqualsTraits use kernel_offset BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/fad8f80afd51c3e057895079811ce0243ab2ac86

Patch Set 1 #

Patch Set 2 : Removed debug printf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -22 lines) Patch
M runtime/vm/kernel.h View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/vm/kernel_binary.cc View 30 chunks +36 lines, -7 lines 0 comments Download
M runtime/vm/kernel_to_il.h View 1 3 chunks +6 lines, -12 lines 0 comments Download
M runtime/vm/kernel_to_il.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
jensj
3 years, 8 months ago (2017-03-30 09:25:48 UTC) #2
Kevin Millikin (Google)
lgtm
3 years, 8 months ago (2017-03-31 12:17:04 UTC) #3
jensj
3 years, 8 months ago (2017-04-03 10:10:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fad8f80afd51c3e057895079811ce0243ab2ac86 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698