audio_manager_cras: Set minimum output buffer size per board

audio_manager_cras: Set minimum output buffer size per board

Add a map to set different minimum output buffer size per board.
We can use smaller minimum output buffer size for powerful board, and
use larger minimum output buffer size for slower board.

BUG=581679
TEST=On kevin board, check block size is 768 on WebAudio test page.
TEST=On samus board, check block size is 256 on WebAudio test page.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2787433002
Cr-Commit-Position: refs/heads/master@{#464411}
Committed: https://chromium.googlesource.com/chromium/src/+/eeedc3696edc5e4be6cf0c7a117ddf04f84745f8

[cychiang, 2017-03-29 09:32:46]

Description was changed from

==========
audio_manager_cras: Set minimum output buffer size per board

Add a map to set different minimum output buffer size per board.
We can use smaller minimum output buffer size for powerful board, and
use larger minimum output buffer size for slower board.

BUG=581679
TEST=On kevin board, check block size is 768 on WebAudio test page.
TEST=On samus board, check block size is 256 on WebAudio test page.
TEST=TODO: test power and glitch on samus.
==========

to

==========
audio_manager_cras: Set minimum output buffer size per board

Add a map to set different minimum output buffer size per board.
We can use smaller minimum output buffer size for powerful board, and
use larger minimum output buffer size for slower board.

BUG=581679
TEST=On kevin board, check block size is 768 on WebAudio test page.
TEST=On samus board, check block size is 256 on WebAudio test page.
TEST=TODO: test power and glitch on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[cychiang, 2017-03-30 10:24:39]

Description was changed from

==========
audio_manager_cras: Set minimum output buffer size per board

Add a map to set different minimum output buffer size per board.
We can use smaller minimum output buffer size for powerful board, and
use larger minimum output buffer size for slower board.

BUG=581679
TEST=On kevin board, check block size is 768 on WebAudio test page.
TEST=On samus board, check block size is 256 on WebAudio test page.
TEST=TODO: test power and glitch on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
audio_manager_cras: Set minimum output buffer size per board

Add a map to set different minimum output buffer size per board.
We can use smaller minimum output buffer size for powerful board, and
use larger minimum output buffer size for slower board.

BUG=581679
TEST=On kevin board, check block size is 768 on WebAudio test page.
TEST=On samus board, check block size is 256 on WebAudio test page.
TEST=TODO: test power and glitch on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[cychiang, 2017-03-30 10:24:39]

cychiang@chromium.org changed reviewers:
+ dalecurtis@chromium.org, dgreid@chromium.org, rtoy@chromium.org

[DaleCurtis, 2017-03-30 16:17:42]

https://codereview.chromium.org/2787433002/diff/1/media/audio/cras/audio_mana...
File media/audio/cras/audio_manager_cras.cc (right):

https://codereview.chromium.org/2787433002/diff/1/media/audio/cras/audio_mana...
media/audio/cras/audio_manager_cras.cc:49: const std::map<std::string, int>
kCustomizedOutputBufferSizeMap = {
This is a static initializer, you should instead just code these values in the
function.

[cychiang, 2017-04-07 08:45:42]

Thanks!I will do the power and underrun testing.

https://codereview.chromium.org/2787433002/diff/1/media/audio/cras/audio_mana...
File media/audio/cras/audio_manager_cras.cc (right):

https://codereview.chromium.org/2787433002/diff/1/media/audio/cras/audio_mana...
media/audio/cras/audio_manager_cras.cc:49: const std::map<std::string, int>
kCustomizedOutputBufferSizeMap = {
On 2017/03/30 16:17:42, DaleCurtis wrote:
> This is a static initializer, you should instead just code these values in the
> function.

Done.

[DaleCurtis, 2017-04-10 19:40:55]

lgtm assuming the boards actually work.

[cychiang, 2017-04-13 13:50:27]

Tested power consumption and glitches on issue tracker.
Thanks!

[cychiang, 2017-04-13 13:52:56]

Description was changed from

==========
audio_manager_cras: Set minimum output buffer size per board

Add a map to set different minimum output buffer size per board.
We can use smaller minimum output buffer size for powerful board, and
use larger minimum output buffer size for slower board.

BUG=581679
TEST=On kevin board, check block size is 768 on WebAudio test page.
TEST=On samus board, check block size is 256 on WebAudio test page.
TEST=TODO: test power and glitch on samus.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
audio_manager_cras: Set minimum output buffer size per board

Add a map to set different minimum output buffer size per board.
We can use smaller minimum output buffer size for powerful board, and
use larger minimum output buffer size for slower board.

BUG=581679
TEST=On kevin board, check block size is 768 on WebAudio test page.
TEST=On samus board, check block size is 256 on WebAudio test page.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[cychiang, 2017-04-13 13:53:27]

The CQ bit was checked by cychiang@chromium.org

[cychiang, 2017-04-13 13:53:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/2787433002/#ps40001
(title: "audio_manager_cras: Set minimum output buffer size per board")

[commit-bot: I haz the power, 2017-04-13 13:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 15:23:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492091607475760,
"parent_rev": "ef481283f456d4667e01a8a765f20ad32ffc3f0a", "commit_rev":
"eeedc3696edc5e4be6cf0c7a117ddf04f84745f8"}

[commit-bot: I haz the power, 2017-04-13 15:24:00]

Description was changed from

==========
audio_manager_cras: Set minimum output buffer size per board

Add a map to set different minimum output buffer size per board.
We can use smaller minimum output buffer size for powerful board, and
use larger minimum output buffer size for slower board.

BUG=581679
TEST=On kevin board, check block size is 768 on WebAudio test page.
TEST=On samus board, check block size is 256 on WebAudio test page.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
audio_manager_cras: Set minimum output buffer size per board

Add a map to set different minimum output buffer size per board.
We can use smaller minimum output buffer size for powerful board, and
use larger minimum output buffer size for slower board.

BUG=581679
TEST=On kevin board, check block size is 768 on WebAudio test page.
TEST=On samus board, check block size is 256 on WebAudio test page.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2787433002
Cr-Commit-Position: refs/heads/master@{#464411}
Committed:
https://chromium.googlesource.com/chromium/src/+/eeedc3696edc5e4be6cf0c7a117d...
==========

[commit-bot: I haz the power, 2017-04-13 15:24:03]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eeedc3696edc5e4be6cf0c7a117d...