Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: media/audio/cras/audio_manager_cras.cc

Issue 2787433002: audio_manager_cras: Set minimum output buffer size per board (Closed)
Patch Set: audio_manager_cras: Set minimum output buffer size per board Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/audio/cras/audio_manager_cras.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/cras/audio_manager_cras.cc
diff --git a/media/audio/cras/audio_manager_cras.cc b/media/audio/cras/audio_manager_cras.cc
index 65a2f66d43d228d2856ca1242c3e62bd46d94889..da6aeef47f76cda14362403f96bfd8ce3a2e642d 100644
--- a/media/audio/cras/audio_manager_cras.cc
+++ b/media/audio/cras/audio_manager_cras.cc
@@ -16,6 +16,7 @@
#include "base/nix/xdg_util.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
+#include "base/sys_info.h"
#include "chromeos/audio/audio_device.h"
#include "chromeos/audio/cras_audio_handler.h"
#include "media/audio/audio_device_description.h"
@@ -265,12 +266,23 @@ AudioInputStream* AudioManagerCras::MakeLowLatencyInputStream(
return MakeInputStream(params, device_id);
}
+int AudioManagerCras::GetMinimumOutputBufferSizePerBoard() {
+ // On faster boards we can use smaller buffer size for lower latency.
+ // On slower boards we should use larger buffer size to prevent underrun.
+ std::string board = base::SysInfo::GetLsbReleaseBoard();
+ if (board == "kevin")
+ return 768;
+ else if (board == "samus")
+ return 256;
+ return kMinimumOutputBufferSize;
+}
+
AudioParameters AudioManagerCras::GetPreferredOutputStreamParameters(
const std::string& output_device_id,
const AudioParameters& input_params) {
ChannelLayout channel_layout = CHANNEL_LAYOUT_STEREO;
int sample_rate = kDefaultSampleRate;
- int buffer_size = kMinimumOutputBufferSize;
+ int buffer_size = GetMinimumOutputBufferSizePerBoard();
int bits_per_sample = 16;
if (input_params.IsValid()) {
sample_rate = input_params.sample_rate();
« no previous file with comments | « media/audio/cras/audio_manager_cras.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698