Moves couple of WmShell methods to standalone functions

Moves couple of WmShell methods to standalone functions

Specifically GetActiveWindow(), GetFocusedWindow() and
GetCaptureWindow().

BUG=687660
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2787363002
Cr-Commit-Position: refs/heads/master@{#461224}
Committed: https://chromium.googlesource.com/chromium/src/+/9e1148fba194af58c68f064be85a02ac5abafb56

[sky, 2017-03-31 15:31:11]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 15:31:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 15:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 15:35:10]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sky, 2017-03-31 15:46:00]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 15:46:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 16:14:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 16:14:26]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2017-03-31 19:29:52]

LGTM. Your bot failures look like compile in an uncommon test suite.

Also, not for this CL, is there going to be a WmWindow -> aura::Window cleanup
at some point?

https://codereview.chromium.org/2787363002/diff/40001/ash/common/wm/fullscree...
File ash/common/wm/fullscreen_window_finder.cc (right):

https://codereview.chromium.org/2787363002/diff/40001/ash/common/wm/fullscree...
ash/common/wm/fullscreen_window_finder.cc:9: #include "ash/common/wm_shell.h"
nit: still needed?

https://codereview.chromium.org/2787363002/diff/40001/ash/common/wm/maximize_...
File ash/common/wm/maximize_mode/maximize_mode_event_handler.cc (right):

https://codereview.chromium.org/2787363002/diff/40001/ash/common/wm/maximize_...
ash/common/wm/maximize_mode/maximize_mode_event_handler.cc:11: #include
"ash/common/wm_shell.h"
still needed?

https://codereview.chromium.org/2787363002/diff/40001/ash/wm/window_util.h
File ash/wm/window_util.h (right):

https://codereview.chromium.org/2787363002/diff/40001/ash/wm/window_util.h#ne...
ash/wm/window_util.h:41: ASH_EXPORT aura::Window* GetCaptureWindow();
nit: Can you write a comment for this?

[sky, 2017-03-31 20:15:07]

The CQ bit was checked by sky@chromium.org

[sky, 2017-03-31 20:15:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2787363002/#ps60001
(title: "feedback and fix applist")

[sky, 2017-03-31 20:15:14]

There is indeed a bug filed on removing WmWindow.

https://codereview.chromium.org/2787363002/diff/40001/ash/common/wm/fullscree...
File ash/common/wm/fullscreen_window_finder.cc (right):

https://codereview.chromium.org/2787363002/diff/40001/ash/common/wm/fullscree...
ash/common/wm/fullscreen_window_finder.cc:9: #include "ash/common/wm_shell.h"
On 2017/03/31 19:29:52, James Cook wrote:
> nit: still needed?

Done.

https://codereview.chromium.org/2787363002/diff/40001/ash/common/wm/maximize_...
File ash/common/wm/maximize_mode/maximize_mode_event_handler.cc (right):

https://codereview.chromium.org/2787363002/diff/40001/ash/common/wm/maximize_...
ash/common/wm/maximize_mode/maximize_mode_event_handler.cc:11: #include
"ash/common/wm_shell.h"
On 2017/03/31 19:29:52, James Cook wrote:
> still needed?

Done.

https://codereview.chromium.org/2787363002/diff/40001/ash/wm/window_util.h
File ash/wm/window_util.h (right):

https://codereview.chromium.org/2787363002/diff/40001/ash/wm/window_util.h#ne...
ash/wm/window_util.h:41: ASH_EXPORT aura::Window* GetCaptureWindow();
On 2017/03/31 19:29:52, James Cook wrote:
> nit: Can you write a comment for this?

I kind of figured it was obvious (similar to lack of comments for similar
getters above), but I'll add one.

[commit-bot: I haz the power, 2017-03-31 20:15:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 20:59:12]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490991307787240,
"parent_rev": "acb782439b5218aec440085b2560487bd344f7ef", "commit_rev":
"9e1148fba194af58c68f064be85a02ac5abafb56"}

[commit-bot: I haz the power, 2017-03-31 21:00:00]

Description was changed from

==========
Moves couple of WmShell methods to standalone functions

Specifically GetActiveWindow(), GetFocusedWindow() and
GetCaptureWindow().

BUG=687660
TEST=covered by tests
R=jamescook@chromium.org
==========

to

==========
Moves couple of WmShell methods to standalone functions

Specifically GetActiveWindow(), GetFocusedWindow() and
GetCaptureWindow().

BUG=687660
TEST=covered by tests
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2787363002
Cr-Commit-Position: refs/heads/master@{#461224}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e1148fba194af58c68f064be85a...
==========

[commit-bot: I haz the power, 2017-03-31 21:00:01]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/9e1148fba194af58c68f064be85a...