Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2787293002: Reland: Move wtf_unittests to platform/wtf/. (Closed)

Created:
3 years, 8 months ago by Yuta Kitamura
Modified:
3 years, 8 months ago
Reviewers:
haraken, Nico
CC:
chromium-reviews, blink-reviews-wtf_chromium.org, dglazkov+blink, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Move wtf_unittests to platform/wtf/. This relands the exact same patch as the previous commit https://codereview.chromium.org/2771783003 did. This patch was reverted because the offending CL was dependent on it. TBRing since the exact same change was approved before. > This patch moves all the cpp files for wtf_unittests to their new home > platform/wtf. The target "wtf_unittests" is removed from wtf/BUILD.gn, and > it's added in platform/wtf/BUILD.gn. Due to this change, a few other files > need to be updated, too. BUG=691465 TBR=haraken@chromium.org,thakis@chromium.org Review-Url: https://codereview.chromium.org/2787293002 Cr-Commit-Position: refs/heads/master@{#461072} Committed: https://chromium.googlesource.com/chromium/src/+/6fbccafc5d50e35d8f8360559829a8b5ece100dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -8688 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ASCIICTypeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/BUILD.gn View 3 chunks +71 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/DequeTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/HashMapTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/HashSetTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/ListHashSetTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/MathExtrasTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/OptionalTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/PassRefPtrTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/RefPtrTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/StringExtrasTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/StringHasherTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/TimeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/TreeNodeTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/TypeTraitsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/VectorTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/dtoa_test.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/testing/RunAllTests.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/AtomicStringTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/CStringTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/IntegerToStringConversionTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringBufferTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringBuilderTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringImplTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringOperatorsTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringToNumberTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/StringViewTest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecICUTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecLatin1Test.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecReplacementTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8Test.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextCodecUserDefinedTest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/TextEncodingTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/wtf/text/WTFStringTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBufferBuilderTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/wtf/ASCIICTypeTest.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/wtf/AssertionsTest.cpp View 1 chunk +0 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/Source/wtf/DequeTest.cpp View 1 chunk +0 lines, -638 lines 0 comments Download
D third_party/WebKit/Source/wtf/FunctionalTest.cpp View 1 chunk +0 lines, -594 lines 0 comments Download
D third_party/WebKit/Source/wtf/HashMapTest.cpp View 1 chunk +0 lines, -715 lines 0 comments Download
D third_party/WebKit/Source/wtf/HashSetTest.cpp View 1 chunk +0 lines, -508 lines 0 comments Download
D third_party/WebKit/Source/wtf/ListHashSetTest.cpp View 1 chunk +0 lines, -822 lines 0 comments Download
D third_party/WebKit/Source/wtf/MathExtrasTest.cpp View 1 chunk +0 lines, -262 lines 0 comments Download
D third_party/WebKit/Source/wtf/OptionalTest.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/wtf/PassRefPtrTest.cpp View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/Source/wtf/RefPtrTest.cpp View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/Source/wtf/StringExtrasTest.cpp View 1 chunk +0 lines, -159 lines 0 comments Download
D third_party/WebKit/Source/wtf/StringHasherTest.cpp View 1 chunk +0 lines, -428 lines 0 comments Download
D third_party/WebKit/Source/wtf/TimeTest.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/wtf/TreeNodeTest.cpp View 1 chunk +0 lines, -215 lines 0 comments Download
D third_party/WebKit/Source/wtf/TypeTraitsTest.cpp View 1 chunk +0 lines, -271 lines 0 comments Download
D third_party/WebKit/Source/wtf/VectorTest.cpp View 1 chunk +0 lines, -725 lines 0 comments Download
D third_party/WebKit/Source/wtf/dtoa_test.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/WebKit/Source/wtf/testing/RunAllTests.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/AtomicStringTest.cpp View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/CStringTest.cpp View 1 chunk +0 lines, -202 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/IntegerToStringConversionTest.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringBufferTest.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringBuilderTest.cpp View 1 chunk +0 lines, -341 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringImplTest.cpp View 1 chunk +0 lines, -160 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringOperatorsTest.cpp View 1 chunk +0 lines, -243 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringToNumberTest.cpp View 1 chunk +0 lines, -126 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/StringViewTest.cpp View 1 chunk +0 lines, -458 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecICUTest.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecLatin1Test.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecReplacementTest.cpp View 1 chunk +0 lines, -61 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecTest.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecUTF8Test.cpp View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextCodecUserDefinedTest.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/TextEncodingTest.cpp View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/wtf/text/WTFStringTest.cpp View 1 chunk +0 lines, -502 lines 0 comments Download
D third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferBuilderTest.cpp View 1 chunk +0 lines, -225 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Yuta Kitamura
Landing as TBR since this is the same as the one you two approved before.
3 years, 8 months ago (2017-03-31 05:32:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787293002/1
3 years, 8 months ago (2017-03-31 05:33:19 UTC) #3
haraken
LGTM
3 years, 8 months ago (2017-03-31 05:40:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/340088)
3 years, 8 months ago (2017-03-31 06:29:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787293002/1
3 years, 8 months ago (2017-03-31 06:31:59 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 07:56:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fbccafc5d50e35d8f8360559829...

Powered by Google App Engine
This is Rietveld 408576698