Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2787213002: arc: Enable UI to send feedback on "Server Communication Error" (Closed)

Created:
3 years, 8 months ago by khmel
Modified:
3 years, 8 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, oshima+watch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Enable UI to send feedback on "Server Communication Error" This is to increase reporting rate for this error. Currently users sent report for this error vary rare. However number in UMA is quite high. TEST=Manually BUG=707062 BUG=b/36785117 Review-Url: https://codereview.chromium.org/2787213002 Cr-Commit-Position: refs/heads/master@{#460986} Committed: https://chromium.googlesource.com/chromium/src/+/9200fc1d36c47ee62054a4e642c171defe986bbd

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/arc/arc_session_manager.cc View 2 chunks +2 lines, -2 lines 3 comments Download

Messages

Total messages: 12 (5 generated)
khmel
Hi Luis, pTAL Thanks
3 years, 8 months ago (2017-03-30 22:50:21 UTC) #2
Luis Héctor Chávez
https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc/arc_session_manager.cc File chrome/browser/chromeos/arc/arc_session_manager.cc (right): https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc/arc_session_manager.cc#newcode314 chrome/browser/chromeos/arc/arc_session_manager.cc:314: support_host_->ShowError(error, true); Do we have any calls where this ...
3 years, 8 months ago (2017-03-30 23:00:12 UTC) #4
khmel
https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc/arc_session_manager.cc File chrome/browser/chromeos/arc/arc_session_manager.cc (right): https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc/arc_session_manager.cc#newcode314 chrome/browser/chromeos/arc/arc_session_manager.cc:314: support_host_->ShowError(error, true); On 2017/03/30 23:00:11, Luis Héctor Chávez wrote: ...
3 years, 8 months ago (2017-03-30 23:01:11 UTC) #5
Luis Héctor Chávez
lgtm https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc/arc_session_manager.cc File chrome/browser/chromeos/arc/arc_session_manager.cc (right): https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc/arc_session_manager.cc#newcode314 chrome/browser/chromeos/arc/arc_session_manager.cc:314: support_host_->ShowError(error, true); On 2017/03/30 23:01:11, khmel wrote: > ...
3 years, 8 months ago (2017-03-30 23:03:14 UTC) #6
khmel
Thank you!
3 years, 8 months ago (2017-03-31 00:49:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787213002/1
3 years, 8 months ago (2017-03-31 00:50:33 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-03-31 01:46:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9200fc1d36c47ee62054a4e642c1...

Powered by Google App Engine
This is Rietveld 408576698