arc: Enable UI to send feedback on "Server Communication Error"

arc: Enable UI to send feedback on "Server Communication Error"

This is to increase reporting rate for this error. Currently users sent
report for this error vary rare. However number in UMA is quite high.

TEST=Manually
BUG=707062
BUG=b/36785117

Review-Url: https://codereview.chromium.org/2787213002
Cr-Commit-Position: refs/heads/master@{#460986}
Committed: https://chromium.googlesource.com/chromium/src/+/9200fc1d36c47ee62054a4e642c171defe986bbd

[khmel, 2017-03-30 22:50:21]

khmel@chromium.org changed reviewers:
+ lhchavez@chromium.org

[khmel, 2017-03-30 22:50:21]

Hi Luis,

pTAL

Thanks

[khmel, 2017-03-30 22:51:00]

Description was changed from

==========
arc: Enable UI to send feedback on "Server Communication Error"

This is to increase reporting rate for this error. Currently users sent
report for this error vary rare. However number in UMA is quite high.

TEST=Manually
BUG=707062
==========

to

==========
arc: Enable UI to send feedback on "Server Communication Error"

This is to increase reporting rate for this error. Currently users sent
report for this error vary rare. However number in UMA is quite high.

TEST=Manually
BUG=707062
BUG=b/36785117
==========

[Luis Héctor Chávez, 2017-03-30 23:00:12]

https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_session_manager.cc (right):

https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_session_manager.cc:314:
support_host_->ShowError(error, true);
Do we have any calls where this is false?

[khmel, 2017-03-30 23:01:11]

https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_session_manager.cc (right):

https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_session_manager.cc:314:
support_host_->ShowError(error, true);
On 2017/03/30 23:00:11, Luis Héctor Chávez wrote:
> Do we have any calls where this is false?

Yes, for "android management check required"

[Luis Héctor Chávez, 2017-03-30 23:03:14]

lgtm

https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_session_manager.cc (right):

https://codereview.chromium.org/2787213002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_session_manager.cc:314:
support_host_->ShowError(error, true);
On 2017/03/30 23:01:11, khmel wrote:
> On 2017/03/30 23:00:11, Luis Héctor Chávez wrote:
> > Do we have any calls where this is false?
> 
> Yes, for "android management check required"

Fair enough.

[khmel, 2017-03-31 00:49:43]

Thank you!

[khmel, 2017-03-31 00:49:48]

The CQ bit was checked by khmel@chromium.org

[commit-bot: I haz the power, 2017-03-31 00:50:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 01:45:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490921388127160, "parent_rev":
"a91c0fc5f433c660fd924cfefa8a4fa09db94ac8", "commit_rev":
"9200fc1d36c47ee62054a4e642c171defe986bbd"}

[commit-bot: I haz the power, 2017-03-31 01:46:36]

Description was changed from

==========
arc: Enable UI to send feedback on "Server Communication Error"

This is to increase reporting rate for this error. Currently users sent
report for this error vary rare. However number in UMA is quite high.

TEST=Manually
BUG=707062
BUG=b/36785117
==========

to

==========
arc: Enable UI to send feedback on "Server Communication Error"

This is to increase reporting rate for this error. Currently users sent
report for this error vary rare. However number in UMA is quite high.

TEST=Manually
BUG=707062
BUG=b/36785117

Review-Url: https://codereview.chromium.org/2787213002
Cr-Commit-Position: refs/heads/master@{#460986}
Committed:
https://chromium.googlesource.com/chromium/src/+/9200fc1d36c47ee62054a4e642c1...
==========

[commit-bot: I haz the power, 2017-03-31 01:46:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9200fc1d36c47ee62054a4e642c1...