arc: Enable UI to send feedback on "Server Communication Error"

chrome/browser/chromeos/arc/arc_session_manager.cc

Index: chrome/browser/chromeos/arc/arc_session_manager.cc
diff --git a/chrome/browser/chromeos/arc/arc_session_manager.cc b/chrome/browser/chromeos/arc/arc_session_manager.cc
index 8a38c01ca6be1597837ae7a97d2a0ade72f898c8..7ef233215e8be3f5a5ee2b8b7989e32e0b6a800a 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager.cc
+++ b/chrome/browser/chromeos/arc/arc_session_manager.cc
@@ -311,7 +311,7 @@ void ArcSessionManager::OnProvisioningFinished(ProvisioningResult result) {
       profile_->GetPrefs()->SetBoolean(prefs::kArcSignedIn, false);
     ShutdownSession();
     if (support_host_)
-      support_host_->ShowError(error, false);
+      support_host_->ShowError(error, true);

[Luis Héctor Chávez, 2017/03/30 23:00:11]

Do we have any calls where this is false?

[khmel, 2017/03/30 23:01:11]

Yes, for "android management check required"

[Luis Héctor Chávez, 2017/03/30 23:03:14]

Fair enough.

     return;
   }
 
@@ -734,7 +734,7 @@ void ArcSessionManager::OnAndroidManagementChecked(
     case policy::AndroidManagementClient::Result::ERROR:
       if (support_host_) {
         support_host_->ShowError(
-            ArcSupportHost::Error::SERVER_COMMUNICATION_ERROR, false);
+            ArcSupportHost::Error::SERVER_COMMUNICATION_ERROR, true);
       }
       UpdateOptInCancelUMA(OptInCancelReason::NETWORK_ERROR);
       break;