third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp - Issue 2787203002: Fix GraphicsLayerUpdater::UpdateContext::compositingContainer() for corner cases

Unified Diff: third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

Issue 2787203002: Fix GraphicsLayerUpdater::UpdateContext::compositingContainer() for corner cases (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

index 206a380497331df2363912b582c1899ed2320b04..6784122e847a4bddf6fa81c4a21ec540e01a8c81 100644

--- a/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp

@@ -56,14 +56,6 @@ class GraphicsLayerUpdater::UpdateContext {

const PaintLayer* compositingContainer(const PaintLayer& layer) const {

if (layer.stackingNode()->isStacked())

return m_compositingStackingContext;

- // TODO(wangxianzhu, chrishtr): This is incorrect if m_compositingAncestor

- // is inline and there is any non-layer floating object between layer and

- // m_compositingAncestor. Should use the logic in PaintLayer::

- // containingLayer().

- if (layer.layoutObject().isFloatingWithNonContainingBlockParent())

- return layer.enclosingLayerWithCompositedLayerMapping(ExcludeSelf);

Xianzhu 2017/03/30 22:23:12 The test (PaintLayerTest.CompositingContainerUnder

chrishtr 2017/03/31 00:12:28 The sequence of patches here was: https://coderev

Xianzhu 2017/03/31 04:14:43 I just review the above CLs and my later related c

return m_compositingAncestor;

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerTest.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayerTest.cpp » ('J')