Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2624843002: Return the enclosing composited PaintLayer rather than containingBlock for floats. (Closed)

Created:
3 years, 11 months ago by chrishtr
Modified:
3 years, 11 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return the enclosing composited PaintLayer rather than containingBlock for floats. A previous patch failed to return the composited PaintLayer, which is what GraphicsLayerUpdater expected. BUG=679667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2624843002 Cr-Commit-Position: refs/heads/master@{#442778} Committed: https://chromium.googlesource.com/chromium/src/+/e00ffecc157dfa92f60c583cd3bfab7f102b65ae

Patch Set 1 #

Patch Set 2 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/compositing/GraphicsLayerUpdater.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerTest.cpp View 2 chunks +18 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
chrishtr
3 years, 11 months ago (2017-01-10 21:48:35 UTC) #4
Xianzhu
lgtm
3 years, 11 months ago (2017-01-10 21:56:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624843002/20001
3 years, 11 months ago (2017-01-10 21:57:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97247)
3 years, 11 months ago (2017-01-10 23:17:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624843002/20001
3 years, 11 months ago (2017-01-10 23:26:07 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/97432)
3 years, 11 months ago (2017-01-11 00:48:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624843002/20001
3 years, 11 months ago (2017-01-11 02:18:32 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 03:22:45 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e00ffecc157dfa92f60c583cd3bf...

Powered by Google App Engine
This is Rietveld 408576698